Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFA using an Authenticator app #292

Merged
merged 104 commits into from
Sep 9, 2024
Merged

MFA using an Authenticator app #292

merged 104 commits into from
Sep 9, 2024

Commits on May 21, 2024

  1. MFA prototype

    @dantownsend
    dantownsend committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8162527 View commit details
    Browse the repository at this point in the history

  2. add mfa_providers abstract property

    @dantownsend
    dantownsend committed May 21, 2024
    Configuration menu
    Copy the full SHA
    58e382a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mfa-prototype

    @dantownsend
    dantownsend committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7e7c2ae View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. flesh out email provider a bit more

    @dantownsend
    dantownsend committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d1ab032 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. wip

    @dantownsend
    dantownsend committed May 30, 2024
    Configuration menu
    Copy the full SHA
    491e216 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. flesh out email some more, and add authenticator

    @dantownsend
    dantownsend committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5988198 View commit details
    Browse the repository at this point in the history

  2. flesh out AuthenticatorSeed some more

    @dantownsend
    dantownsend committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5bf4a2d View commit details
    Browse the repository at this point in the history

  3. add method for fetching pyotp

    @dantownsend
    dantownsend committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ed2d26c View commit details
    Browse the repository at this point in the history

  4. add pyotp to requirements

    @dantownsend
    dantownsend committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    034d181 View commit details
    Browse the repository at this point in the history

  5. add proper auth methods for pyotp

    @dantownsend
    dantownsend committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    08144ab View commit details
    Browse the repository at this point in the history

  6. start adding tests

    @dantownsend
    dantownsend committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ecc9dce View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. bump minimum Piccolo version

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    17a8854 View commit details
    Browse the repository at this point in the history

  2. test create_new method

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6d1e7f2 View commit details
    Browse the repository at this point in the history

  3. add qrcode logic from @sinisaos PR

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9bcaf1f View commit details
    Browse the repository at this point in the history

  4. flesh out auth methods

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f67d543 View commit details
    Browse the repository at this point in the history

  5. lazy load qrcode

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f4c8bf0 View commit details
    Browse the repository at this point in the history

  6. fleshing out logic some more in session login endpoint

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    71f9aee View commit details
    Browse the repository at this point in the history

  7. change imports

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    33dfbf9 View commit details
    Browse the repository at this point in the history

  8. make error messages consistent

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0f4f1fc View commit details
    Browse the repository at this point in the history

  9. add TODO

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c3f4ca3 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into mfa-prototype

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5926327 View commit details
    Browse the repository at this point in the history

  11. adding example app for testing

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    785de93 View commit details
    Browse the repository at this point in the history

  12. add AuthenticatorProvider to example app

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    38bd3bf View commit details
    Browse the repository at this point in the history

  13. added get_registration_html to provider

    @dantownsend
    dantownsend committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7424132 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. rename seed_table to secret_table

    @dantownsend
    dantownsend committed Aug 9, 2024
    2 Configuration menu
    Copy the full SHA
    a2d7719 View commit details
    Browse the repository at this point in the history

  2. change params in send_code for authenticator

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1084b7f View commit details
    Browse the repository at this point in the history

  3. Create README.md

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d59540a View commit details
    Browse the repository at this point in the history

  4. add issuer_name to AuthenticatorProvider

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    15b9c8c View commit details
    Browse the repository at this point in the history

  5. fix typo in docstring

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    62e1bbf View commit details
    Browse the repository at this point in the history

  6. add get_registration_json

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    77b67a1 View commit details
    Browse the repository at this point in the history

  7. add get_registration_json to base class

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9162b9a View commit details
    Browse the repository at this point in the history

  8. try embedding QR code image in HTML response

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e45be09 View commit details
    Browse the repository at this point in the history

  9. flesh out MFARegisterEndpoint endpoint

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c1b1c05 View commit details
    Browse the repository at this point in the history

  10. add todo about primary key

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    cdc5d47 View commit details
    Browse the repository at this point in the history

  11. fix bugs in register endpoint

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d7bd02e View commit details
    Browse the repository at this point in the history

  12. fix error - was returning html instead of json

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    cabf6cd View commit details
    Browse the repository at this point in the history

  13. show MFA code input on login page

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ec69778 View commit details
    Browse the repository at this point in the history

  14. Update README.md

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b4dd816 View commit details
    Browse the repository at this point in the history

  15. Update tests.yaml

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    923e3ef View commit details
    Browse the repository at this point in the history

  16. fix some linter errors

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    4df3da9 View commit details
    Browse the repository at this point in the history

  17. add device_name column to AuthenticatorSecret

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6a5e948 View commit details
    Browse the repository at this point in the history

  18. make sure each provider has a custom token name

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e33a0e4 View commit details
    Browse the repository at this point in the history

  19. make each MFA Provider have a unique token name 

    This means we can potentially put several MFA providers on the login page
    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3345e34 View commit details
    Browse the repository at this point in the history

  20. If the user reused a code make sure auth fails (could be a replay att… 

    …ack)
    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    67dfb6e View commit details
    Browse the repository at this point in the history

  21. add auth test for replay attacks

    @dantownsend
    dantownsend committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ccb3648 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. add generate_recovery_code

    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e314118 View commit details
    Browse the repository at this point in the history

  2. store recovery codes, and return recovery codes in endpoints (taken f… 

    …rom @sinisaos example)
    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    24be31a View commit details
    Browse the repository at this point in the history

  3. make sure recovery codes can be used to login

    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    63e70fd View commit details
    Browse the repository at this point in the history

  4. ignore mypy warnings for now

    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a53f51a View commit details
    Browse the repository at this point in the history

  5. install pyotp in CI

    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2d714e1 View commit details
    Browse the repository at this point in the history

  6. endpoint test WIP

    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    95e6754 View commit details
    Browse the repository at this point in the history

  7. update TestMFARegisterEndpoint

    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    64ef81b View commit details
    Browse the repository at this point in the history

  8. remove todo

    @dantownsend
    dantownsend committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c3a3029 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. encrypt secret in db

    @dantownsend
    dantownsend committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2efd8c9 View commit details
    Browse the repository at this point in the history

  2. use a proper template for MFA sign up

    @dantownsend
    dantownsend committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1e6dc9b View commit details
    Browse the repository at this point in the history

  3. add links for where to download the authenticator app, and add JS for… 

    … copying to clipboard
    @dantownsend
    dantownsend committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    47744dd View commit details
    Browse the repository at this point in the history

  4. also test HTML register endpoint

    @dantownsend
    dantownsend committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ff806e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. add playwright tests

    @dantownsend
    dantownsend committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    605d09b View commit details
    Browse the repository at this point in the history

  2. require a password to enable MFA

    @dantownsend
    dantownsend committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    1f05a1f View commit details
    Browse the repository at this point in the history

  3. fix test

    @dantownsend
    dantownsend committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f525ef3 View commit details
    Browse the repository at this point in the history

  4. create separate template for cancelling MFA

    @dantownsend
    dantownsend committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    033c986 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. initial docs

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    1fd4de9 View commit details
    Browse the repository at this point in the history

  2. improve docs for AuthenticatorProvider params

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    78fd06f View commit details
    Browse the repository at this point in the history

  3. add docs for tables

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d79087b View commit details
    Browse the repository at this point in the history

  4. rename mfa_register_endpoint to mfa_setup 

    So the name is more consistent with other endpoints in `piccolo_api`
    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2902e45 View commit details
    Browse the repository at this point in the history

  5. improve docs, and rename from register to setup

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    28a3ddb View commit details
    Browse the repository at this point in the history

  6. remove debugging

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b20662a View commit details
    Browse the repository at this point in the history

  7. improve template when MFA is disabled

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    3833250 View commit details
    Browse the repository at this point in the history

  8. add re-enabled link on disabled template

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    01e785a View commit details
    Browse the repository at this point in the history

  9. fix linter errors

    @dantownsend
    dantownsend committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8e94d28 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. use self._auth_table

    @dantownsend
    dantownsend committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    f997bbd View commit details
    Browse the repository at this point in the history

  2. render cancel template in GET endpoint if user is already enrolled

    @dantownsend
    dantownsend committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    47e6508 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. remove email for now

    @dantownsend
    dantownsend committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d288cd4 View commit details
    Browse the repository at this point in the history

  2. remove email from README

    @dantownsend
    dantownsend committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    8c6e95d View commit details
    Browse the repository at this point in the history

  3. start moving encryption into its own file

    @dantownsend
    dantownsend committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d4007a1 View commit details
    Browse the repository at this point in the history

  4. update code to use encryption provider

    @dantownsend
    dantownsend committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b7bbf86 View commit details
    Browse the repository at this point in the history

  5. improve the docstring for mfa_setup - mention rate limiting

    @dantownsend
    dantownsend committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ea1dd57 View commit details
    Browse the repository at this point in the history

  6. improve docstrings

    @dantownsend
    dantownsend committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a910d17 View commit details
    Browse the repository at this point in the history

  7. add params to docstrings

    @dantownsend
    dantownsend committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3ff1778 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. remove device_name - not currently used

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    96ca0ae View commit details
    Browse the repository at this point in the history

  2. change revoke_all to revoke 

    The current design assumes a single device per user
    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    210bfa3 View commit details
    Browse the repository at this point in the history

  3. add XChaCha20Provider

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1a21746 View commit details
    Browse the repository at this point in the history

  4. make sure pynacl is installed in tests

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8226e6a View commit details
    Browse the repository at this point in the history

  5. make sure pynacl is installed in tests (continued)

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    eb5bfa5 View commit details
    Browse the repository at this point in the history

  6. improve coverage

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5379bb0 View commit details
    Browse the repository at this point in the history

  7. add TestRevoke

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3e673dd View commit details
    Browse the repository at this point in the history

  8. add a test to make sure auth works

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    780d7ad View commit details
    Browse the repository at this point in the history

  9. remove unused import

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    27f5658 View commit details
    Browse the repository at this point in the history

  10. add tests for recovery codes

    @dantownsend
    dantownsend committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bd5829e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. remove breakpoint

    @dantownsend
    dantownsend committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    81b09e4 View commit details
    Browse the repository at this point in the history

  2. fix bug with prefix

    @dantownsend
    dantownsend committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c8d679c View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. simplify encoding

    @dantownsend
    dantownsend committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    9bc3939 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. changed login logic for multiple MFA providers

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5bcb5cd View commit details
    Browse the repository at this point in the history

  2. make mfa_provider_name param optional if there's only a single MFA … 

    …provider
    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    78de9a9 View commit details
    Browse the repository at this point in the history

  3. add help_text to revoked_at

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4e4a90f View commit details
    Browse the repository at this point in the history

  4. add valid_window argument to AuthenticatorProvider

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    01b7b36 View commit details
    Browse the repository at this point in the history

  5. tell the user whether we sent them a code

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fa727aa View commit details
    Browse the repository at this point in the history

  6. increase coverage for AuthenticatorSecret

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    2fa9962 View commit details
    Browse the repository at this point in the history

  7. remove TODO in endpoint test

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fad9ef2 View commit details
    Browse the repository at this point in the history

  8. add tests for generating recovery codes

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    97c8572 View commit details
    Browse the repository at this point in the history

  9. fix path to AuthenticatorProvider in docstring

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4f38884 View commit details
    Browse the repository at this point in the history

  10. add docs for encryption

    @dantownsend
    dantownsend committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    98953be View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. remove imports

    @dantownsend
    dantownsend committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d4f4b5b View commit details
    Browse the repository at this point in the history

  2. add docstring and type annotations to get_b64encoded_qr_image

    @dantownsend
    dantownsend committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5974031 View commit details
    Browse the repository at this point in the history