-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans for dropping PHP < 5.3 support #38
Comments
It could be worth the combined effort to create a PHPTALv2 for PHP >= 5.3.3. Besides Support for namespaces, this would also allow for the use of Closures. It would also allow upgrading to PHPUnit 4 (which allows for more precise coverage definitions for the unit test). |
Yes, we shouldn't support PHP versions that are obsolete. |
So I guess it's PHP5.4 then. Or should we start over with 5.5? |
Given how few backward incompatibilities PHP5.5 has in regards to 5.4, it could be worth having 5.5 as "main" version (bacwards compatibility for 5.4 from 5.5 is rather trival, except for the |
IMHO:
|
@pornel PHP5.4 EOL is obviously in 2015 so maybe we should consider to skip it? http://php.net/archive/2014.php#id2014-08-14-1 |
@usox if you make a pull request with some hot new stuff that requires php5.5, can do :) |
I will (at laest I'll try :) ). Should we create a new branch for the coming PRs or should I use the master? |
Please develop features on a branch. |
@Ocramius Do you think we should take a stab at this? Maybe set up a v2 branch? |
@Potherca only if v2 deprecates installation methods that are not composer-based. If we can switch to composer-only, then we can upgrade PHP version requirements gradually, as it doesn't consist in a BC break (users will simply be given an older compatible version). If v2 lands with other installation methods, then every PHP version requirement bump will result in a BC break instead :-( |
I am all for composer-only install. I've taken the liberty of summarising what I think need doing for the README file. We could define more things that we think/feel need to be improved and set a v2 milestone? |
Also: I suggest keeping v2 very minimal (removing features/cleanups, mostly) in order to get some swing for working on new functionality (v2.* or v3). |
Agreed. The main focus for me would be on cleanup/docs (to get a firm grasp of the current state of things) and removing things that are marked deprecated (either in TAL or in PHP) to be more "future proof". Having a clean baseline should also help get some more people on board when I start promoting PHPTAL more widely in my personal network... |
@Potherca If you need some help regarding the docs/cleanup, tell me. |
@Ocramius Not sure whether we should close this issue (as PHP 5.3 is no longer supported) or rename it to "Start using namespaces" as that seems to be more what this thread is about. Ideas? |
Let's just close this 👍 |
Hi there
Just a quick question: Do you have any plans dropping the support for php < 5.3 in future releases? I'm going to write a patch (at least I'll try) which add Namespaces and Interfaces which will break the compatibilty to the current supported versions of php (php 5.1.x?).
The text was updated successfully, but these errors were encountered: