Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for dropping PHP < 5.3 support #38

Closed
usox opened this issue Nov 15, 2014 · 19 comments
Closed

Any plans for dropping PHP < 5.3 support #38

usox opened this issue Nov 15, 2014 · 19 comments
Labels

Comments

@usox
Copy link
Contributor

usox commented Nov 15, 2014

Hi there

Just a quick question: Do you have any plans dropping the support for php < 5.3 in future releases? I'm going to write a patch (at least I'll try) which add Namespaces and Interfaces which will break the compatibilty to the current supported versions of php (php 5.1.x?).

@Potherca
Copy link
Member

It could be worth the combined effort to create a PHPTALv2 for PHP >= 5.3.3. Besides Support for namespaces, this would also allow for the use of Closures.

It would also allow upgrading to PHPUnit 4 (which allows for more precise coverage definitions for the unit test).

@kornelski
Copy link
Contributor

Yes, we shouldn't support PHP versions that are obsolete.

@usox
Copy link
Contributor Author

usox commented Nov 17, 2014

So I guess it's PHP5.4 then. Or should we start over with 5.5?

@Potherca
Copy link
Member

Given how few backward incompatibilities PHP5.5 has in regards to 5.4, it could be worth having 5.5 as "main" version (bacwards compatibility for 5.4 from 5.5 is rather trival, except for the class contant and yield and finally.

@kornelski
Copy link
Contributor

IMHO:

  • PHPTAL should run out of the box on PHP 5.4 (oldest supported PHP version)
  • Where possible, it should be aware and conditionally take advantage of newer PHP features (e.g. could we use generators in tal:repeat?)

@usox
Copy link
Contributor Author

usox commented Nov 20, 2014

@pornel PHP5.4 EOL is obviously in 2015 so maybe we should consider to skip it? http://php.net/archive/2014.php#id2014-08-14-1

@kornelski
Copy link
Contributor

@usox if you make a pull request with some hot new stuff that requires php5.5, can do :)

@usox
Copy link
Contributor Author

usox commented Nov 21, 2014

I will (at laest I'll try :) ).

Should we create a new branch for the coming PRs or should I use the master?

@kornelski
Copy link
Contributor

Please develop features on a branch.

@Potherca
Copy link
Member

@Ocramius Do you think we should take a stab at this? Maybe set up a v2 branch?

@Ocramius
Copy link
Member

@Potherca only if v2 deprecates installation methods that are not composer-based.

If we can switch to composer-only, then we can upgrade PHP version requirements gradually, as it doesn't consist in a BC break (users will simply be given an older compatible version).

If v2 lands with other installation methods, then every PHP version requirement bump will result in a BC break instead :-(

@Potherca
Copy link
Member

I am all for composer-only install. I've taken the liberty of summarising what I think need doing for the README file. We could define more things that we think/feel need to be improved and set a v2 milestone?

@Ocramius
Copy link
Member

@Potherca track everything you want to get done for a v2 in issues, then set the milestone (created v2.0.0) and find people who can get those done for you :)

@Ocramius
Copy link
Member

Also: I suggest keeping v2 very minimal (removing features/cleanups, mostly) in order to get some swing for working on new functionality (v2.* or v3).
Don't try adding stuff, or you'll be stuck quicker than ever.

@Ocramius Ocramius added this to the v2.0.0 milestone Aug 31, 2015
@Potherca
Copy link
Member

Agreed. The main focus for me would be on cleanup/docs (to get a firm grasp of the current state of things) and removing things that are marked deprecated (either in TAL or in PHP) to be more "future proof".

Having a clean baseline should also help get some more people on board when I start promoting PHPTAL more widely in my personal network...

@usox
Copy link
Contributor Author

usox commented Aug 31, 2015

@Potherca If you need some help regarding the docs/cleanup, tell me.

@Potherca
Copy link
Member

@usox Feel free to comment on issue #41 if you think I missed anything (or have further suggestions).

@Potherca Potherca mentioned this issue Aug 31, 2015
5 tasks
@Potherca
Copy link
Member

Potherca commented Mar 6, 2022

@Ocramius Not sure whether we should close this issue (as PHP 5.3 is no longer supported) or rename it to "Start using namespaces" as that seems to be more what this thread is about. Ideas?

@Ocramius
Copy link
Member

Ocramius commented Mar 6, 2022

Let's just close this 👍

@Ocramius Ocramius closed this as completed Mar 6, 2022
@Ocramius Ocramius removed this from the 2.0.0 milestone Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants