Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing configure flags for pie build does not result in a full rebuild #93

Open
TimWolla opened this issue Nov 15, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TimWolla
Copy link
Member

Working with #83:

I'm not sure if my Makefile / configure script is incorrectly written and does not properly handle the build dependencies, but given the fact that pie always runs both phpize and ./configure for each build, it would probably make sense to run the equivalent of git clean -fdx in the build directory to ensure that the build is internally consistent. Even if the build infrastructure is actually faulty, this could otherwise lead to hard-to-debug issues.

@asgrim asgrim self-assigned this Nov 15, 2024
@asgrim asgrim added the enhancement New feature or request label Nov 15, 2024
@asgrim
Copy link
Collaborator

asgrim commented Nov 15, 2024

Yep this is a reasonable improvement we could make - I do think we should clean first. This would only be observable if you are rebuilding an already downloaded version (e.g. pie build a/a:1.2.3 then pie build a/a:1.2.3 --some-flag); otherwise Composer will rip out the source and replace it anyway.

@asgrim asgrim removed their assignment Nov 15, 2024
@asgrim asgrim added the good first issue Good for newcomers label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants