Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysqli test cases using fake_server are flaky #16875

Open
cmb69 opened this issue Nov 20, 2024 · 1 comment
Open

Mysqli test cases using fake_server are flaky #16875

cmb69 opened this issue Nov 20, 2024 · 1 comment

Comments

@cmb69
Copy link
Member

cmb69 commented Nov 20, 2024

Description

I've just stumbled upon https://github.com/php/php-src/actions/runs/11942808872/job/33290600427. The test uses port 50001 which is otherwise not explicitly used by the php-src test suite, but might be used by a test using an ephemeral port. I'm not sure, though, that a port collision is the cause of the test failure.

However, the other regression test for that issue all use port 33305 (which is also the default of the fake server); this is prone to collisions when running tests in parallel.

I think it's best to use ephemeral ports everywhere (see #6132).

PHP Version

PHP-8.4 (likely 8.1 - master)

Operating System

Windows (likely POSIX as well)

@cmb69
Copy link
Member Author

cmb69 commented Nov 20, 2024

Oh, just noticed that the mysqli test suite is marked as conflicting (mysql) anyway. So it's certainly not that bad. Still, there seems to be room for improvement, and at least the actual test failure mentioned above should be sorted out, ideally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant