Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The argument names for various Imagick methods are incorrect #4118

Open
stefanfisk opened this issue Nov 21, 2024 · 1 comment · May be fixed by #4120
Open

The argument names for various Imagick methods are incorrect #4118

stefanfisk opened this issue Nov 21, 2024 · 1 comment · May be fixed by #4120

Comments

@stefanfisk
Copy link

From manual page: https://php.net/imagickdraw.rectangle

The argument names for ImagickDraw::rectangle() and a bunch of other Imagick methods are wrong.

Compare https://www.php.net/manual/en/imagickdraw.rectangle.php to https://github.com/Imagick/imagick/blob/28f27044e435a2b203e32675e942eb8de620ee58/ImagickDraw.stub.php#L77.

The official stub matches the actual code https://github.com/Imagick/imagick/blob/28f27044e435a2b203e32675e942eb8de620ee58/ImagickDraw_arginfo.h#L378.
@Girgias
Copy link
Member

Girgias commented Nov 21, 2024

The documentation hasn't been updated in a while as it is "external" to php-src.

But if there is a stub file you should be able to create an PR with automatic fixes using the php-src build/gen_stub.php --replace-methodsynopsis ../path/to/imagick/stub.php ../path/to/doc-en/reference/imagick

stefanfisk added a commit to stefanfisk/php-doc-en that referenced this issue Nov 21, 2024
@stefanfisk
Update Imagick method synopses (php#4118)
aa1c9ac 
The argument names where wrong for a lot of methods.
@stefanfisk stefanfisk linked a pull request Nov 21, 2024 that will close this issue
Open
stefanfisk added a commit to stefanfisk/php-doc-en that referenced this issue Nov 22, 2024
@stefanfisk
Update Imagick method synopses (php#4118)
3580683 
The argument names where wrong for a lot of methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Imagick method synopses (#4118) stefanfisk/php-doc-en
2 participants
@stefanfisk @Girgias