Missing backwards-incompatible change in PHP 8

[danielscsc]

From manual page: https://php.net/function.proc-open

---

In PHP 8.0, proc_open changed that it now runs (in Windows) cmd /s /c always.

See:
php/php-src@9ca449e

It is mentioned in the migration guide as well:
https://www.php.net/manual/en/migration80.incompatible.php#:~:text=now%20consistently%20execute-,%25comspec%25,-/s%20/c%20%22%24commandline

I think this should be noted in the proc_open page itself. I recently upgraded some servers from PHP 7.2 to 8.2, and this line of code, which used to work stopped working:

    $cmd = '"C:\\path\\to\\exe.exe '.$cssfile.'"';
    $descriptorspec = array(0 => array("pipe", "r"), 1 => array("pipe", "w"), 2 => array("pipe", "w"));
    $process = proc_open($cmd, $descriptorspec, $pipes, $swffontdir);

The documentation for proc_open does mention changes regarding to escaping when using array as args, but not that the old string version also did.

Also, this is now misleading, as we pass /s /c:

Note: On Windows, unless bypass_shell is set to true in options, the command is passed to cmd.exe (actually, %ComSpec%) with the /c flag as unquoted string