Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests if PR is installable with Symfony and Laravel #141

Open
andig opened this issue Sep 16, 2018 · 4 comments
Open

Add CI tests if PR is installable with Symfony and Laravel #141

andig opened this issue Sep 16, 2018 · 4 comments

Comments

@andig
Copy link
Contributor

andig commented Sep 16, 2018

No description provided.

@dnna
Copy link
Contributor

dnna commented Sep 17, 2018

There is already something for this in travis from what I can see https://github.com/php-pm/php-pm-httpkernel/blob/master/.travis.yml#L20

Is this just a matter of adding
composer create-project laravel/laravel blog
and
composer create-project symfony/skeleton blog

in the script section in travis.yml?

@andig
Copy link
Contributor Author

andig commented Sep 17, 2018

Noticed the need during php-pm/php-pm#431.

Is this just a matter of adding...

The tricky part is installing the current PR into the generated framework project. Only approach I could find was fiddling with local composer repositories (https://getcomposer.org/doc/05-repositories.md#path)?

@dnna
Copy link
Contributor

dnna commented Sep 17, 2018

Leaving Travis aside, what are the steps to reproduce those issues from scratch?

  1. Create Symfony/Laravel project
  2. cd to created project folder
  3. composer require php-pm/httpkernel-adapter (with some fiddling with composer repos to ensure this pulls the PR instead of the live version)

Are these the correct steps to test?

@dnna
Copy link
Contributor

dnna commented Sep 17, 2018

Actually now that I think of it, can't we just replace the line in travis.yml:
composer require --dev "symfony/symfony" "laravel/framework" "drupal/drupal"
with:
composer require --dev "symfony/framework-standard-edition" "laravel/laravel" "drupal/drupal"

This will widen the scope of the dependencies to what the actual frameworks install and should catch those conflicts.

Edit: To be more correct we should split this line to install laravel, symfony and drupal separately, since each framework may install conflicting dependencies with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants