Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includeConstructors, includeAccessors and generateBuilders have no effect on POJOs #201

Open
yuranos opened this issue Nov 14, 2017 · 6 comments
Labels
enhancement v2 Feature will be implemented in v2.0 only (master branch)

Comments

@yuranos
Copy link
Contributor

yuranos commented Nov 14, 2017

There might be problems with other, but those 3 are not working properly for sure.

@yuranos
Copy link
Contributor Author

yuranos commented Nov 15, 2017

@stojsavljevic , FYI. If you have something to add.

@stojsavljevic
Copy link
Contributor

They are used when generating POJOs from JSON schemas.
Unfortunately, generating POJOs from schema has completely different code path but generation from types.

@yuranos
Copy link
Contributor Author

yuranos commented Nov 15, 2017

@stojsavljevic , that's why maybe it would be easier to add lombok for now. I will check the code in more detail.

@stojsavljevic
Copy link
Contributor

Relates to #255

@stojsavljevic stojsavljevic added bug v2 Feature will be implemented in v2.0 only (master branch) labels May 15, 2018
@stojsavljevic
Copy link
Contributor

Some of these flags will not be implemented for data types.
The reason for that is implementation complexity. Also, I don't see much value in some of them.
I need to check one by one to see if the implementation makes sense.

@stojsavljevic stojsavljevic removed the bug label May 24, 2018
@stojsavljevic
Copy link
Contributor

generateBuilders is already implemented for data types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement v2 Feature will be implemented in v2.0 only (master branch)
Projects
None yet
Development

No branches or pull requests

2 participants