Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boto dependency shouldn't be foreced #39

Open
giyaseddin opened this issue Oct 30, 2023 · 5 comments
Open

Boto dependency shouldn't be foreced #39

giyaseddin opened this issue Oct 30, 2023 · 5 comments

Comments

@giyaseddin
Copy link

I'm getting botocore dependency despite I'm just regularly installing the package. Either it should be added dependency or specified in the install like: easyllm[aws]

Rolling back to v0.5.0 solved the issue for now.

@philschmid
Copy link
Owner

What error are you getting? can you please share it?

@giyaseddin
Copy link
Author

giyaseddin commented Nov 6, 2023

    from easyllm.clients import huggingface
../../../../../miniconda3/envs/llm-poc/lib/python3.11/site-packages/easyllm/clients/huggingface.py:9: in <module>
    from easyllm.prompt_utils.base import build_prompt, buildBasePrompt
../../../../../miniconda3/envs/llm-poc/lib/python3.11/site-packages/easyllm/prompt_utils/base.py:5: in <module>
    from easyllm.utils import setup_logger
../../../../../miniconda3/envs/llm-poc/lib/python3.11/site-packages/easyllm/utils/__init__.py:1: in <module>
    from easyllm.utils.aws import AWSSigV4, get_bedrock_client
../../../../../miniconda3/envs/llm-poc/lib/python3.11/site-packages/easyllm/utils/aws.py:10: in <module>
    from botocore.config import Config
E   ModuleNotFoundError: No module named 'botocore'
================================================================================ warnings summary =================================================================================
../../../../../miniconda3/envs/llm-poc/lib/python3.11/site-packages/pydantic/_internal/_config.py:219
../../../../../miniconda3/envs/llm-poc/lib/python3.11/s

by just running the import. I just got a fresh install (got easyllm==0.6.0) and that's the only change that was applied.

Reproduce:

pip install easyllm --upgrade
>>> from easyllm.clients import huggingface
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/giyaseddin/miniconda3/envs/llm-main/lib/python3.11/site-packages/easyllm/clients/huggingface.py", line 9, in <module>
    from easyllm.prompt_utils.base import build_prompt, buildBasePrompt
  File "/home/giyaseddin/miniconda3/envs/llm-main/lib/python3.11/site-packages/easyllm/prompt_utils/base.py", line 5, in <module>
    from easyllm.utils import setup_logger
  File "/home/giyaseddin/miniconda3/envs/llm-main/lib/python3.11/site-packages/easyllm/utils/__init__.py", line 1, in <module>
    from easyllm.utils.aws import AWSSigV4, get_bedrock_client
  File "/home/giyaseddin/miniconda3/envs/llm-main/lib/python3.11/site-packages/easyllm/utils/aws.py", line 10, in <module>
    from botocore.config import Config
ModuleNotFoundError: No module named 'botocore'

@philschmid
Copy link
Owner

Let me look at that but. You should be able to install pip install easyllm[bedrock]

@philschmid
Copy link
Owner

I pushed an updated version.

@murdadesmaeeli
Copy link

This issue seems to be closable @philschmid .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants