You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
The inclusion of $logger->info('resolve', array('url' => $url, 'json' => $json)) in the resolve callback results in kilobytes of clutter being dumped to the debug output every time a YouTube video is looked up. Unless the user is actively debugging the plugin, there's no need to dump all this output.
Personally, I'd prefer a simple debug message along the lines of YouTube API data received {"id":"VIDEOID"}. Would be interested to know what others think.
The text was updated successfully, but these errors were encountered:
I think this sounds reasonable. Maybe add a 'debug' flag to configuration that, when set to true, dumps the current output, else it dumps output in the format you've suggested for simpler debugging?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The inclusion of
$logger->info('resolve', array('url' => $url, 'json' => $json))
in the resolve callback results in kilobytes of clutter being dumped to the debug output every time a YouTube video is looked up. Unless the user is actively debugging the plugin, there's no need to dump all this output.Personally, I'd prefer a simple debug message along the lines of
YouTube API data received {"id":"VIDEOID"}
. Would be interested to know what others think.The text was updated successfully, but these errors were encountered: