-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] SystemDependenciesTest is failing #16826
Comments
This should be fixed by: pharo-spec/NewTools#797 |
this is fixed |
There is still one. StProtocolChooserPresenter depends on Commander 1 and is in NewTools-Core. I think I'll introduce a package NewTools-Calypso. Make this package load before Calypso in Pharo. And then move the StProtocolChooserPresenter there so that the Commander 1 dependency is loaded later and that we remove the dependency Here is the first step PR: pharo-spec/NewTools#805 |
Hum.. In fact I see that we do not use NewTools groups for now. So I'm not sure it's the best solution. It might be better to add methods referencing Commander1 as extensions for now |
I did this PR to fix the problem: pharo-spec/NewTools#806 |
I merged the PR |
Bug description
Tests in SystemDependenciesTest started failing e.g. testExternalBasicToolsDependencies
It is not clear which is the reason for the problem, it seems we merged multiple (mininum 3, maybe more) PRs that intruduce many failing tests.
The text was updated successfully, but these errors were encountered: