Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] SystemDependenciesTest is failing #16826

Closed
MarcusDenker opened this issue Jun 28, 2024 · 6 comments
Closed

[CI] SystemDependenciesTest is failing #16826

MarcusDenker opened this issue Jun 28, 2024 · 6 comments

Comments

@MarcusDenker
Copy link
Member

Bug description
Tests in SystemDependenciesTest started failing e.g. testExternalBasicToolsDependencies

It is not clear which is the reason for the problem, it seems we merged multiple (mininum 3, maybe more) PRs that intruduce many failing tests.

Given Collections do not match!
	additions : #('NewTools-CodeCritiques')
	missing: #()

SystemDependenciesTest(TestAsserter)>>assert:description:resumable:
SystemDependenciesTest(TestAsserter)>>assert:description:
SystemDependenciesTest(TestAsserter)>>assertCollection:hasSameElements:
SystemDependenciesTest>>testExternalBasicToolsDependencies
@jecisc
Copy link
Member

jecisc commented Jul 17, 2024

This should be fixed by: pharo-spec/NewTools#797

@MarcusDenker
Copy link
Member Author

this is fixed

@jecisc jecisc reopened this Jul 18, 2024
@jecisc
Copy link
Member

jecisc commented Jul 18, 2024

There is still one.

StProtocolChooserPresenter depends on Commander 1 and is in NewTools-Core.

I think I'll introduce a package NewTools-Calypso. Make this package load before Calypso in Pharo. And then move the StProtocolChooserPresenter there so that the Commander 1 dependency is loaded later and that we remove the dependency

Here is the first step PR: pharo-spec/NewTools#805

@jecisc
Copy link
Member

jecisc commented Jul 18, 2024

Hum.. In fact I see that we do not use NewTools groups for now. So I'm not sure it's the best solution.

It might be better to add methods referencing Commander1 as extensions for now

@jecisc
Copy link
Member

jecisc commented Jul 18, 2024

I did this PR to fix the problem: pharo-spec/NewTools#806

@MarcusDenker
Copy link
Member Author

I merged the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants