Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] testThatThereAreNoSelectorsRemainingThatAreSentButNotImplemented #16825

Closed
MarcusDenker opened this issue Jun 28, 2024 · 3 comments · Fixed by #16906
Closed

[CI] testThatThereAreNoSelectorsRemainingThatAreSentButNotImplemented #16825

MarcusDenker opened this issue Jun 28, 2024 · 3 comments · Fixed by #16906
Assignees
@hernanmd
Labels
Type: Bug

Comments

@MarcusDenker
Copy link
Member

MarcusDenker commented Jun 28, 2024 •
edited
Loading

Bug description
testThatThereAreNoSelectorsRemainingThatAreSentButNotImplemented is failing. A PR (it looks even two) got merged that had code that sends unknown selectors:

ReClassForGeneratingEqualAndHashExistingImplementors>>#=' 

'StInspectorTransmissionNode class>>#hostObject:transmissionBlock:'
This was referenced Jun 28, 2024
Merged
Closed
@hernanmd hernanmd self-assigned this Jun 28, 2024
@MarcusDenker
Copy link
Member Author

ReClassForGeneratingEqualAndHashExistingImplementors is test data, so this is not just a trivial cleanup

@hernanmd hernanmd mentioned this issue Jul 2, 2024
Merged
@unfurl-links unfurl-links bot mentioned this issue Jul 3, 2024
Closed
@MarcusDenker
Copy link
Member Author

Failing now due to

  • MetaLinkAnonymousClassBuilderTest>>#testMigrateObjectToOriginalClass
  • MetaLinkAnonymousClassBuilderTest>>#testMigrateObjectToAnonymousClass
  • MetaLinkInstaller>>#reinstallPermaLink:onNode:
  • StInspectorTransmissionNode class>>#hostObject:transmissionBlock:

This was referenced Jul 5, 2024
Merged
Merged
@MarcusDenker
Copy link
Member Author

Just one left:

MetaLinkInstaller>>#reinstallPermaLink:onNode:

@MarcusDenker MarcusDenker mentioned this issue Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hernanmd hernanmd

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix testThatThereAreNoSelectorsRemainingThatAreSentButNotImplemented MarcusDenker/pharo
2 participants
@MarcusDenker @hernanmd