Patches for 4.37.21586

[pgaskin]

• Upload testdata (@pgaskin)
• Extract resources (@pgaskin)
• Find libnickel offsets where necessary (@pgaskin)
• Update most patches (@pgaskin)
• Test patches (@pgaskin)
• Make release (@pgaskin)
• MR post (@pgaskin)
• Later (from Patches for 4.34.20097 #112): Add Clara/Elipsa 2E to koboutils (@pgaskin)
• Migrate CI to GitHub Actions #122

[pgaskin]

Resource extraction:

go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21586.qInitResources_styles.zip --recursive --verbose nickel 1 26572352 26432304 26560712
go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21586.qInitResources_resources.zip --recursive --verbose nickel 1 21580752 101096 21579424
go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21586.qInitResources_certificates.zip --recursive --verbose nickel 1 26733760 26575600 26729584
go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21586.qInitResources_translations.zip --recursive --verbose nickel 1 26431976 21581792 26431232

Output Diff

---

https://krc.storage.pgaskin.net/nickel.21586.qInitResources_certificates.zip
https://krc.storage.pgaskin.net/nickel.21586.qInitResources_resources.zip
https://krc.storage.pgaskin.net/nickel.21586.qInitResources_styles.zip
https://krc.storage.pgaskin.net/nickel.21586.qInitResources_translations.zip

[pgaskin]

  /home/patrick/kp/src/kobopatch-patches/src/versions/4.37.21586/libnickel.so.1.0.0.yaml/pgaskin.yaml: Customize ComfortLight settings: could not apply patch "Customize ComfortLight settings": line 529: inst 4: ReplaceInt: could not find specified bytes at offset
  /home/patrick/kp/src/kobopatch-patches/src/versions/4.37.21586/nickel.yaml/pgaskin.yaml: Increase size of kepub chapter progress chart: could not apply patch "Increase size of kepub chapter progress chart": line 28: inst 4: ReplaceZlib: not a zlib stream
  /home/patrick/kp/src/kobopatch-patches/src/versions/4.37.21586/nickel.yaml/pgaskin.yaml: Remove forgot pin button from lock screen: could not apply patch "Remove forgot pin button from lock screen": line 20: inst 4: ReplaceZlib: not a zlib stream

Another easy one.

[pgaskin]

Released: v83, MR:thread-354944.

[pgaskin]

$ git diff v82:src/versions/4.37.21582 v83:src/versions/4.37.21586

diff --git a/libnickel.so.1.0.0.yaml/pgaskin.yaml b/libnickel.so.1.0.0.yaml/pgaskin.yaml
index 5a6ea98..8ac9e41 100644
--- a/libnickel.so.1.0.0.yaml/pgaskin.yaml
+++ b/libnickel.so.1.0.0.yaml/pgaskin.yaml
@@ -522,7 +522,7 @@ Customize ComfortLight settings:
   # In an unnamed subroutine two layers into FrontLightPopupController::loadView
   # (find it by going back from QTime::addSecs), the times for the dropdown are
   # generated into a QVector<QPair<QString, QTime>> with a simple loop.
-  - BaseAddress: 0xE7D454 # find the base of the unnamed subroutine with the x-ref to _ZN5QTimeC1Eiiii
+  - BaseAddress: 0xE7D464 # find the base of the unnamed subroutine with the x-ref to _ZN5QTimeC1Eiiii
   #
   # Change the initial hour / first bedtime dropdown item passed to the QTime
   # constructor (mov r1, #21):
diff --git a/nickel.yaml/pgaskin.yaml b/nickel.yaml/pgaskin.yaml
index e45b4ea..a6fda61 100644
--- a/nickel.yaml/pgaskin.yaml
+++ b/nickel.yaml/pgaskin.yaml
@@ -15,7 +15,7 @@ Remove forgot pin button from lock screen:
       Removes the Forgot PIN -> Sign Out button from the lock screen.
       If this is enabled and you forget your pin, you will need to
       hard reset your Kobo.
-  - BaseAddress: 0x1941D52 # qss/PinCodeInputDialog.qss
+  - BaseAddress: 0x19460E3 # qss/PinCodeInputDialog.qss
   - ReplaceZlib:
       Find: "#lblForgotPin[qApp_deviceIsDragon=true],\n#lblSignOut[qApp_deviceIsDragon=true] {\n  font-size: 26px;\n}"
       Replace: "#lblForgotPin,#lblSignOut{qproperty-visible:false;}"
@@ -23,7 +23,7 @@ Remove forgot pin button from lock screen:
 Increase size of kepub chapter progress chart:
   - Enabled: no
   - Description: Originally by oren64, rewritten for 4.16.13337 by pgaskin (geek1011).
-  - BaseAddress: 0x194BEA7 # qss/ReadingMenuStatsView.qss
+  - BaseAddress: 0x194EE6F # qss/ReadingMenuStatsView.qss
   - ReplaceZlibGroup:
       Replacements:
       # Top padding is already set to 15px, 25px, 33px, vertical aligned to middle.