Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu_mem=16 doesn't work (missing start4cd.elf and fixup4cd.dat) #58

Closed
andreiw opened this issue May 30, 2020 · 6 comments
Closed

gpu_mem=16 doesn't work (missing start4cd.elf and fixup4cd.dat) #58

andreiw opened this issue May 30, 2020 · 6 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@andreiw
Copy link
Member

andreiw commented May 30, 2020

When gpu_mem=16 is set in config.txt, the "cut down" version of VPU fw is loaded (e.g. without codecs and other bloat) - start4cd (start_cd for non-Pi4) and fixup4cd (fixup_cd for non-Pi 4).

I suggest distributing the full thes of *.elf and *.dat files with our ZIP-packages releases.

See raspberrypi/firmware#959

@pbatard
Copy link
Member

pbatard commented May 30, 2020

I don't think we want to do that.

The firmware archive is meant to contain only the files it needs for the config.txt provided (the only exception being the miniuart overlay for the Pi3, but that's because we explicitly document how to switch UARTs in the EDK2 docs) and that's it.

You do understand that if we start going that route then logically, we have to provide all of the .dtbo overlays from https://github.com/raspberrypi/firmware/tree/master/boot/overlays, because is we do start to cater to people using whatever possible option they can have in their config.txt then we have no other logical choice than see it all the way through.

In other words, we can't just cherry pick files that are relevant to someone's wish to use a specific config.txt option and not automatically include all of the other ones.

Hence the reasoning of not including any of the firmware files that are not relevant to the default config.txt that comes with the archive. And since gpu_mem=16 is not being used, I see no reason to add start4cd. Users who do want to use gpu_mem=16 should provide that file themselves.

I also don't expect many users to have a requirement for this, which is another reason not to include it. If it was likely that 1% of the people downloading the zip were going to use gpu_mem=16 eventually, then it might make sense to add it. But one can be pretty confident that this is not going to be the case.

@andreiw
Copy link
Member Author

andreiw commented May 30, 2020

That’s fair. How about we mandate gpu_mem=16?

@pbatard
Copy link
Member

pbatard commented May 30, 2020

I'm not sure I see the point of doing so. If there's a majority for it, sure, but I'd rather stick with the usual "element of least surprise" and keep config.txt in line with what one would expect for a regular non UEFI boot.

What exactly do we think we have to gain from using gpu_mem=16, that's not going to incur us having to explain "Why are you guys using gpu_mem=16 and start4cd.elf?" on semi regular basis?

In other words, as far as I'm concerned, the less original we try to be with config.txt and the firmware binaries, the better. But that's just my vote.

@andreiw
Copy link
Member Author

andreiw commented Jun 1, 2020

Got it. Fair enough.

@andreiw andreiw closed this as completed Jun 1, 2020
@andreiw andreiw added the wontfix This will not be worked on label Jun 1, 2020
@kpfleming
Copy link

I can understand the reasoning here, but I'm thankful that @andreiw opened this and I looked through the closed issues :-) Maybe it would be useful to have an FAQ to provide guidance for not-common but also not-rare configurations like this (and also things like disable-bt and disable-wifi overlays)?

@Nebucatnetzer
Copy link

I just discovered this issue and disable Bluetooth and Wi-Fi on all my Pis.
Can I just put the files to the right place and it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants