Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setupFrustum bug #30

Open
ShihanWang opened this issue Jun 25, 2019 · 0 comments
Open

setupFrustum bug #30

ShihanWang opened this issue Jun 25, 2019 · 0 comments

Comments

@ShihanWang
Copy link

in open_chisel/src/camera/PinholeCamera.cpp function: void PinholeCamera::SetupFrustum(const Transform& view, Frustum* frustum) const, line 2 where Frustum::SetFromParams(xxx) was used, but the 4th param should not be intrinsics.GetFx() ?
the code is :
void PinholeCamera::SetupFrustum(const Transform& view, Frustum* frustum) const
{
assert(frustum != nullptr);
frustum->SetFromParams(view, nearPlane, farPlane, intrinsics.GetFy(), intrinsics.GetFy(), intrinsics.GetCx(), intrinsics.GetCy(), width, height);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant