How to overwrite redirect URL after login in all cases

[hansegucker]

We have to overwrite the redirect URL for all login actions via social account, even if next is set. Does anyone know how to do this?

[pennersr]

Check out the post_login() adapter method. You can do something like:

def post_login(self, *args, **kwargs):
  resp = super().post_login(*args, **kwargs)
  sociallogin= kwargs.get('signal_kwargs', {}).get('sociallogin')
  if sociallogin:
    raise ImmediateHttpResponse(HttpResponseRedirect('/some/where'))
  return resp

[iamunadike]

this is what I have so far , my initial url is like so @pennersr @hansegucker @cdcarter @jezdez @
1 . http://localhost:8000/auth/signin/?next=//shop.apps.local:8000/store/checkout&type=customer
2. http://localhost:8000/auth/signin/?next=/store/checkout&type=customer
for 1 , the redirect_url is None {'email_verification': <EmailVerificationMethod.OPTIONAL: 'optional'>, 'redirect_url': None, 'signal_kwargs': {'sociallogin': <allauth.socialaccount.models.SocialLogin object at 0x107128e50>}, 'signup': False, 'email': None} , but for 2 it shows , so my question now is {'email_verification': <EmailVerificationMethod.OPTIONAL: 'optional'>, 'redirect_url': '/store/checkout, 'signal_kwargs': {'sociallogin': <allauth.socialaccount.models.SocialLogin object at 0x107128e50>}, 'signup': False, 'email': None}

from allauth.account.adapter import DefaultAccountAdapter
from allauth.socialaccount.adapter import DefaultSocialAccountAdapter
from django.conf import settings
from django.core.exceptions import ValidationError
from authx.models import User
from authx.views import role_based_redirect


class SocialAccountAdapter(DefaultSocialAccountAdapter):

    def get_connect_redirect_url(self, request):
        next_url = request.GET.get('next', settings.DEFAULT_RE
DIRECT_URL)
        return role_based_redirect(request.user, next_url)

    def is_open_for_signup(self, request, sociallogin):
        # Logic to allow or prevent signups
        return True

    def get_login_redirect_url(self, request):
        import pdb
        pdb.set_trace()
        next_url = request.GET.get('next', "")
        return role_based_redirect(request.user, next_url)

    def pre_social_login(self, request, sociallogin):
        return super().pre_social_login(request, sociallogin)



class GAccountAdapter(DefaultAccountAdapter):

    def post_login(self, *args, **kwargs):
        import pdb
        pdb.set_trace()
        resp = super().post_login(*args, **kwargs)
        sociallogin = kwargs.get('signal_kwargs', {}).get('sociallogin')
        if sociallogin:
            raise Exception('Social login')
            # ImmediateHttpResponse(HttpResponseRedirect('/some/where'))
        return resp

    def get_login_redirect_url(self, request):
        import pdb
        pdb.set_trace()
        next_url = request.GET.get('next', "")
        return '/me/posts/'

[iamunadike]

Check out the post_login() adapter method. You can do something like:

def post_login(self, *args, **kwargs):
  resp = super().post_login(*args, **kwargs)
  sociallogin= kwargs.get('signal_kwargs', {}).get('sociallogin')
  if sociallogin:
    raise ImmediateHttpResponse(HttpResponseRedirect('/some/where'))
  return resp

can you help @pennersr i asked a ? , the next or redirect_url is not working as it is None for a subdomain which should not be , it works well in django but it only works for cases of normal url like '/some/place' it needs to be flexible to alow redirects to anywhere, I stand to be corrected so fix

[pennersr]

@iamunadike I suggest you work a bit on your social skills. Impatiently paging various people, and this...

Dumb enough this is a persistent bug i suppose on this project, yet the long nosed creature is yet to fix it. Fix it
I stand to be corrected so fix

... really isn't helping.

Having said that, do check the account adapter is_safe_url() method. Likely your subdomain isn't considered to be safe.

[iamunadike]

Having said that, do check the account adapter is_safe_url() method. Likely your subdomain isn't considered to be safe.
@pennersr
thanks first and foremost for the reply, but i have been on this for the past 48hours and its consuming most of my time , this is why i lashed out on my first reach. that said, the issue here is
not is_safe_url(deprecated for url_has_allowed_host_and_scheme) because i had apps.local and subdomains on my allowed host and mapped in my dns /etc/hosts file , so this is what happens with normal authentication, using my custom user and password it works perfectly and the redirect is perfect ( this aspect does not leverage allauth) , Allauth is being implemented on my app strictly for social logins , in the case of which is google, i noticed it works with same domain like
next= //localhost:8000
provided the root is localhost:8000 , next observation is after the redirect , the interceptions calls the accountadapter custom adapter, from pre to post logins , howbeit with a next=//shops.apps.local:8000/andsoon
the redirect_url is None, but if its just next='/some/destination' it redirect_url will display it, so I ask for answer. thanks in anticipation

[pennersr]

@iamunadike If you find that some next URLs work, and some don't, then the only logical explanation I can think of is the is_safe_url(). So even if you have set up ALLOWED_HOSTS correctly, do give it a try and override is_safe_url() and just return True for testing purposes, regardless of the input. Other than that, I have no idea what is going on in your case, so if that does not work, you'll have to do some debugging...

[iamunadike]

Thanks much but can you give me say a code piece I already cited that is_safe_url is deprecated or is there a method in django-all auth that is so What functions or other method should I target Some code base would be much appreciated

…

On Tue, 29 Oct 2024 at 19:39, Raymond Penners ***@***.***> wrote: @iamunadike <https://github.com/iamunadike> If you find that some next URLs work, and some don't, then the only logical explanation I can think of is the is_safe_url(). So even if you have set up ALLOWED_HOSTS correctly, do give it a try and override is_safe_url() and just return True for testing purposes, regardless of the input. Other than that, I have no idea what is going on in your case, so if that does not work, you'll have to do some debugging... — Reply to this email directly, view it on GitHub <#3881 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALRDXFRZ4DVZ4MNUAOTW5UDZ57I6VAVCNFSM6AAAAABJCX6X76VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMBZGEZDCNI> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[pennersr]

https://codeberg.org/allauth/django-allauth/src/branch/main/allauth/account/adapter.py#L556

[iamunadike]

thanks @pennersr the is_safe_url works but can you share how to access other parameters to the url , assuming I passed ?next= followed by &type=somthing , how can I access the type parameter

[iamunadike]

Hello @pennersr thanks once again, but right now I face one more issue witht the django all auth

from allauth.account.adapter import DefaultAccountAdapter
from allauth.socialaccount.adapter import DefaultSocialAccountAdapter
from django.conf import settings
from authx.views import role_based_redirect


class SocialAccountAdapter(DefaultSocialAccountAdapter):

  

    def post_login(self,  *args, **kwargs):
        # remember to
        resp = super().post_login(*args, **kwargs)
        next_url = kwargs.get('redirect_url', '')
        import pdb
        pdb.set_trace()
        sociallogin = kwargs.get('signal_kwargs', {}).get('sociallogin')
        if sociallogin:
            return role_based_redirect(sociallogin.user, next_url)
        return resp

    def get_login_redirect_url(self, request):
        import pdb
        pdb.set_trace()
        next_url = request.GET.get('next', "")
        return '/me/posts/'
        # return role_based_redirect(request.user, next_url)


class GAccountAdapter(DefaultAccountAdapter):

    def post_login(self,  *args, **kwargs):
        resp = super().post_login(*args, **kwargs)
        next_url = kwargs.get('redirect_url', '')
        import pdb
        pdb.set_trace()
        sociallogin = kwargs.get('signal_kwargs', {}).get('sociallogin')
        if sociallogin:
            return role_based_redirect(sociallogin.user, next_url)
        return resp

    def get_login_redirect_url(self, request):
        # account
        import pdb
        pdb.set_trace()
        next_url = request.GET.get('next', "")
        return '/me/posts/' 

i am using social allauth, and return is_safe_url to true to handle all domains used in rediect howbeit, i dont know which function can get the type value . the url is this **http://localhost:8000/auth/signin/?next=//shop.apps.local:8000/store/checkout&type=customer**. So my question is getting the value of parameter, ie &type=something obvious from . Please HELP TO ANSWER THIS AND SAVE ME TIME

[iamunadike]

Hello @pennersr
can you help with that last part, at least i understand this is your project and I appreciate that but I need help understanding how to use other parameters aside next, i am able to now get the 'next' but others parameters i dont know how to get and its not visible from the docs so help,it takes you a few mins todo this. no vex

[iamunadike]

Hello @pennersr
can you help with that last part, at least i understand this is your project and I appreciate that but I need help understanding how to use other parameters aside next, i am able to now get the 'next' but others parameters i dont know how to get and its not visible from the docs so help,it takes you a few mins todo this. no vex , Can you help? , i dont get why you doing this , the docs are not showing much on these areas , so to save time can you be kind enough