Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label showing 'name, country' #30

Open
missinglink opened this issue May 15, 2019 · 1 comment
Open

label showing 'name, country' #30

missinglink opened this issue May 15, 2019 · 1 comment

Comments

@missinglink
Copy link
Member

missinglink commented May 15, 2019

In the case where we don't have a locality name the labels can be very vague such as this one which just says KFC, South Africa

      "properties": {
        "id": "way/640077183",
        "gid": "openstreetmap:venue:way/640077183",
        "layer": "venue",
        "source": "openstreetmap",
        "source_id": "way/640077183",
        "name": "KFC",
        "street": "Main Reef Road",
        "accuracy": "point",
        "country": "South Africa",
        "country_gid": "whosonfirst:country:85633813",
        "country_a": "ZAF",
        "region": "Gauteng",
        "region_gid": "whosonfirst:region:85688923",
        "region_a": "GT",
        "county": "West Rand",
        "county_gid": "whosonfirst:county:1108730543",
        "county_a": "WR",
        "continent": "Africa",
        "continent_gid": "whosonfirst:continent:102191573",
        "label": "KFC, South Africa"
      },
@orangejulius
Copy link
Member

We fixed this for just the US by allowing county to be used in labels if locality and localadmin are not found. I'm not sure that's valid globally, but we could find a similar solution on a country by country basis if needed.

See https://github.com/pelias/labels/blob/master/labelSchema.js#L85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants