Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail if PELIAS_CONFIG environment variable is set #27

Open
orangejulius opened this issue May 12, 2016 · 2 comments
Open

Tests fail if PELIAS_CONFIG environment variable is set #27

orangejulius opened this issue May 12, 2016 · 2 comments

Comments

@orangejulius
Copy link
Member

orangejulius commented May 12, 2016

I set PELIAS_CONFIG in my .bashrc file so that pelias.json does not clutter up my home directory. However, I have to unset that variable in order for the tests to pass.

@missinglink
Copy link
Member

missinglink commented Aug 15, 2016

see setup() and teardown() functions here for an example of how to avoid this issue.

It might be best to create a more formal way of enforcing the default config during testing across all our repos.

@orangejulius
Copy link
Member Author

We've started using proxyquire in some places with relatively good results. I like that it completely removes any dependency on the actual pelias-config code, the filesystem, and env vars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants