Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCX data truncated to last lap boundary #27

Closed
pcolby opened this issue Aug 10, 2014 · 1 comment
Closed

TCX data truncated to last lap boundary #27

pcolby opened this issue Aug 10, 2014 · 1 comment
Assignees
@pcolby
Labels
defect ready for release
Milestone
0.2.2

Comments

@pcolby
Copy link
Owner

pcolby commented Aug 10, 2014

This bug was introduced in 0.2.1, as part of the lap data support adding in that release.
@pcolby pcolby added the defect label Aug 10, 2014
@pcolby pcolby added this to the 0.2.2 milestone Aug 10, 2014
@pcolby pcolby self-assigned this Aug 10, 2014
@pcolby pcolby changed the title TCX data being truncated to last lap boundary TCX data truncated to last lap boundary Aug 10, 2014
@pcolby pcolby mentioned this issue Aug 11, 2014
Closed
pcolby added a commit that referenced this issue Aug 12, 2014
@pcolby
Prevent TCX data truncation when using laps (#27)
ce10339 
This is fairly extensive refactor of the TrainingSession::toTCX
function to loop through samples instead of looping through laps, since
the latter results in trailing samples being left out.
pcolby added a commit that referenced this issue Aug 12, 2014
@pcolby
Add stats for trailing lap (#27)
0a9f011
@pcolby pcolby added the done label Aug 12, 2014
@pcolby
Copy link
Owner Author

pcolby commented Aug 12, 2014

This has been fixed. Will be released as 0.2.2 soon.

@pcolby pcolby closed this as completed Aug 12, 2014
@pcolby pcolby mentioned this issue Aug 22, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcolby pcolby

Labels
defect ready for release
Projects
None yet
Milestone
0.2.2
Development

No branches or pull requests
1 participant
@pcolby