Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vw and vh units in subtitles #234

Open
ghost opened this issue Jun 10, 2021 · 1 comment
Open

Support vw and vh units in subtitles #234

ghost opened this issue Jun 10, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 10, 2021

I have a TTML/DFXP subtitle file that pycaption can't parse due to vw and vh units:

CaptionReadSyntaxError: CaptionReadSyntaxError((ValueError('The specified value is not valid because its unit is not recognized: 80vw. The only supported units are: PIXEL, EM, PERCENT, CELL, PT'),))

It would be nice to have support for those units. I have attached an example file.

example.zip

@ianShifrin
Copy link

I don't believe that vw and vh are in the original TTML spec. I do think a similar concept was adopted in TTML2, but using the unit names rw, rh as they are relative to the root container region and not the viewport. You can see the discussion here, w3c/ttml2#181

All this said, given our resource availability and workload, unfortunately we will not be able to tackle this request at this moment. We hope to come back to this at a later time if and when resources permit us to.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant