From 7dd0dca570c2a4c9b25efc9d4de9723531a75be5 Mon Sep 17 00:00:00 2001 From: Dougie Squire <42455466+dougiesquire@users.noreply.github.com> Date: Mon, 22 Jan 2024 21:32:18 +1100 Subject: [PATCH 1/2] fix upload/download artifact in CD.yml --- .github/workflows/CD.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CD.yml b/.github/workflows/CD.yml index f3b8be68..4ec0c67f 100644 --- a/.github/workflows/CD.yml +++ b/.github/workflows/CD.yml @@ -23,9 +23,10 @@ jobs: - run: | python3 -m pip install --upgrade build && python3 -m build - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: - path: ./dist + name: release + path: dist pypi-publish: # Split build and publish to restrict trusted publishing to just this workflow @@ -36,9 +37,10 @@ jobs: # IMPORTANT: this permission is mandatory for trusted publishing id-token: write steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: - path: artifact/ + name: release + path: dist - name: Publish package distributions to PyPI uses: pypa/gh-action-pypi-publish@2f6f737ca5f74c637829c0f5c3acd0e29ea5e8bf # v1.8.11 From e606ef824a971260665934062305a2974a7487c3 Mon Sep 17 00:00:00 2001 From: Dougie Squire <42455466+dougiesquire@users.noreply.github.com> Date: Mon, 22 Jan 2024 21:54:55 +1100 Subject: [PATCH 2/2] Remove packages-dir from pypi publish --- .github/workflows/CD.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/CD.yml b/.github/workflows/CD.yml index 4ec0c67f..d3c5fd3c 100644 --- a/.github/workflows/CD.yml +++ b/.github/workflows/CD.yml @@ -44,8 +44,6 @@ jobs: - name: Publish package distributions to PyPI uses: pypa/gh-action-pypi-publish@2f6f737ca5f74c637829c0f5c3acd0e29ea5e8bf # v1.8.11 - with: - packages-dir: artifact/ conda: name: Build with conda and upload