New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloseableIteratorImpl does not return connection to DataSource #34

Open

evsinev opened this issue Feb 3, 2024 · 0 comments

Contributor

evsinev commented Feb 3, 2024

StoredProcedureDaoInvocationHandler promises that Connection will be closed but CloseableIteratorImpl does not close Connection.

    /**
     * Call iterator with closing ResultSet and CallableStatement with Connection.close()
     *
     * @param aArgs         arguments
     * @param methodInvoker method invoker
     * @return iterator
     * @throws SQLException on sql exception
     */
    private Object callIterator(Object[] aArgs, DaoMethodInvoker methodInvoker) throws SQLException {

There are two modes:

transaction scope. A transaction manager will close the Connection at the end of the transaction.
without transaction. In this mode we should return the Connection to the DataSource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment