fix(ui): filter out fields with disableListFilter in whereBuilder prior to adding conditions #10112
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue with the WhereBuilder where if the first field in a collection had
disableListFilterenabled, the select in that fieldsConditionwould be rendered disabled, making it impossible to query docs in list view.Why?
To allow users to query their documents while still being able to set
disableListFilteron fields regardless of where they are in the collection hierarchy.How?
By filtering out unfilterable fields earlier in WhereBuilder and Condition components.
Fixes #10110
Before:
Dashboard-wherebuilder-before--Payload.webm
After:
Dashboard-wherebuilder-after--Payload.webm