Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault integration not working properly? Towny/EssentialsX issues #33

Open
TKwSni opened this issue Mar 17, 2019 · 4 comments
Open

Vault integration not working properly? Towny/EssentialsX issues #33

TKwSni opened this issue Mar 17, 2019 · 4 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@TKwSni
Copy link

TKwSni commented Mar 17, 2019

After testing your pugin with these two, I dont know if other plugins missbehave.

Towny
Creating a towny town, doesnt works,
First it adds uuids to town accounts, which it shouldnt as towns arent players
Second it generates this error:
https://pastebin.com/raw/YbHPvQ1C

EssentialsX,

Balances are not sync, ie:
/eco give doesnt add money to the craftconomy accounts.

All this worked on older versions of the plugin even on 1.13.2.

spigot 1.13.2
vault 1.7.1
craftconomy 3.5.1

@TKwSni TKwSni changed the title Vault integration not working properly? Towny/Essential issues Vault integration not working properly? Towny/EssentialsX issues Mar 17, 2019
@pavog
Copy link
Owner

pavog commented Mar 17, 2019

Towny

I found out that Towny uses balances for towns. So it handles towns like players and tries to update their balance like a player. Unfortunately craftconomy tries to resolve the world of the player to check which balance / account it should use and a town does not have a location and world like a player has.
I need to implement a workaround for this location / world check if the checked object is not a player or just use a more general check for the location.

EssentialsX

I think that EssentialsX uses their own economy system. Since /eco is a command that belongs to EssentialsX and EssentialsX does not sync with any other economy plugin because it uses their own economy plugin this behaviour is the expected.

@pavog pavog added the Type: Bug Something isn't working label Mar 17, 2019
@pavog pavog self-assigned this Mar 17, 2019
@TKwSni
Copy link
Author

TKwSni commented Mar 17, 2019

Yes essentials has a economy system, but when other economy plugin is added, they both are usually in sync, on CraftConomy 3.3.1 worked like that, and I think it's because essentials economy cannot be disabled and to avoid issues with other plugins they both work in sync? maybe.

@pavog
Copy link
Owner

pavog commented Mar 18, 2019

Ah yes, I found this article that proves your assumption. It seems like the connection from Vault to CraftConomy does not work like expected. I need to investigate further on this.

@Weark
Copy link

Weark commented May 12, 2019

I'm having similar problems, and I do not want to abandon the craftcononey3 plugin because it's great.
Once you fix, compile, and release the download for everyone, it will help a lot of people.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants