Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: what is picture_file for? #42

Closed
Ao1Pointblank opened this issue Jun 24, 2024 · 1 comment
Closed

Question: what is picture_file for? #42

Ao1Pointblank opened this issue Jun 24, 2024 · 1 comment
Labels
question Further information is requested

Comments

@Ao1Pointblank
Copy link

Ao1Pointblank commented Jun 24, 2024

i was browsing the code and discovered references to a picture file.
i am wondering if this is for sending an android app icon, or if it is for sending attached images from notifications (like in messenger apps).

i can't seem to get it to work either way, and some messenger apps don't even seem to send notifications at all.

some testing i did with different apps:

  • signal/molly/signal-foss: no notifications at all
  • discord: text only; will show image attachments as text names (image.png)
  • aosp messenger (default android sms): text only (if a message is mms it will not be shown by the server)
  • a2ln test notification: uses the default "info" icon on linux notify-send
@Ao1Pointblank Ao1Pointblank added the question Further information is requested label Jun 24, 2024
@patri9ck
Copy link
Owner

patri9ck commented Aug 5, 2024

picture_file stores the content of getLargeIcon, which may for example be a profile picture in WhatsApp. I also noticed that sometimes there is no picture when there should be but I didn't bother taking a look at it because it seems to be intended (by Android). If there is no icon (getLargeIcon returns null), the server sets dialog-information as the icon whose exact look is desktop dependent.

@patri9ck patri9ck closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants