Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ROOT_URL variable is not respected in hyperlinks from home page #15

Open
aadibajpai opened this issue Jun 1, 2020 · 2 comments · Fixed by aadibajpai/blog#1 or NilsIrl/bm#1 · May be fixed by #16
Open

[BUG] ROOT_URL variable is not respected in hyperlinks from home page #15

aadibajpai opened this issue Jun 1, 2020 · 2 comments · Fixed by aadibajpai/blog#1 or NilsIrl/bm#1 · May be fixed by #16

Comments

@aadibajpai
Copy link
Contributor

If you're at https://aadibajpai.com/blog/ and you try clicking on any of the links in the ToC then they will be broken, but if you open the post and then navigate then they'll work as expected.

I assume this one is as simple as inserting that ROOT_URL variable wherever the toc generation takes place 🤔
@NilsIrl NilsIrl mentioned this issue Jun 10, 2020
Merged
@aadibajpai aadibajpai reopened this Jun 10, 2020
@NilsIrl NilsIrl linked a pull request Jun 10, 2020 that will close this issue
Open
@aadibajpai
Copy link
Contributor Author

Looks like it's not respected from the "All Posts" page either https://aadibajpai.com/blog/posts/index.html, all links from here are broken

@aadibajpai
Copy link
Contributor Author

same for https://aadibajpai.com/blog/tags/index.html, I think the issue is that no ROOT_URL is present in https://github.com/pastly/bm/blob/master/internal/globals.sh#L183 and https://github.com/pastly/bm/blob/master/internal/globals.sh#L241

@aadibajpai aadibajpai mentioned this issue Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@aadibajpai