Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum Python version, especially because fromisoformat() #42

Open
aeetos opened this issue Oct 21, 2021 · 0 comments
Open

Specify minimum Python version, especially because fromisoformat() #42

aeetos opened this issue Oct 21, 2021 · 0 comments

Comments

@aeetos
Copy link
Collaborator

aeetos commented Oct 21, 2021

The present library does not specify a minimum Python version in setup.py.

Some aspects of the analyzer module depend on datetime.fromisoformat() which is only available in Python 3.7 or earlier. Specifying 3.7 as the minimum version is the obvious fix, but may introduce problems for dependent libraries.

After testing and research, we likely need to target 3.6 as the minimum version, but that will require we implement some kind of backport for fromisoformat().

Until this is implemented, users who want to use date-specific functionality in the analyzer in Python versions earlier than 3.7 may want to consider this project (not yet tested by this library's authors):
https://github.com/movermeyer/backports.datetime_fromisoformat

Originally raised by @2xyo in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant