Decoding an invalid uuid shouldn't work

[soyuka]

Hi,

When we try to decode something that isn't a valid uuid it works, IMO it should throw an error:

$uuid = 'notanuuid';
(new ShortUuid())->decode($uuid); // should throw

[juliangut]

I've just bumped into this problem

The thing is decoding 'notanuuid' actually returns '00000000-0000-0000-000e-23c92ffab638' which by Ramsey's validation regex is perfectly valid as per this issue comment

So I guess what can be done right now is accept that any UUID that comes out of decode method is valid (as per Ramsey's) or at best add a check to validate UUID version and variant against RFC 4122

Validation is just being moved to a validator class for version 4.x, so lets hope for different kinds of validators to be available

Edit:
You can have a look at how I've implemented it: https://github.com/phpgears/identity/blob/master/src/ShortUuidIdentity.php