Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of comm buffers across containers #1149

Open
pgrete opened this issue Aug 7, 2024 · 0 comments
Open

Reuse of comm buffers across containers #1149

pgrete opened this issue Aug 7, 2024 · 0 comments
Labels
discussion enhancement New feature or request

Comments

@pgrete
Copy link
Collaborator

pgrete commented Aug 7, 2024

Following a discussion along

          We don't have any control over that and I agree that if you had a task list that had independent groups of tasks that worked on different containers but also communicated you could possibly run into issues where one container grabs messages meant for another container. That is similar to some of the issues I had to fix for multi-grid in this PR. I am not sure what the best approach to dealing with this is. Making buffers for each container doesn't seem ideal and it could be a little tricky to build buffers and MPI tag maps for multiple containers in the current framework (since now buffers are built right after remesh, not at the point when containers are first asked for). Maybe we should put up a warning issue about this.

Originally posted by @lroberts36 in #1143 (comment)

it might be worth to think about how to handle this situation.
One potential way is see is to add a "requres_comm` flag (for comm id) to tasks so that in the task list we can check that only tasks with the same flag/id are processed within a single region.

@pgrete pgrete added enhancement New feature or request discussion labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant