Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix flaky test invalid server state: initialized #2183

Merged
merged 10 commits into from
Jun 25, 2024
Merged

ci: Fix flaky test invalid server state: initialized #2183

merged 10 commits into from
Jun 25, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 23, 2024 •
edited by mtrezza
Loading

Pull Request

Issue

Attempt to fix flaky tests when the server isn't properly initialized. I believe this is caused by tests that shuts down the server to reproduce a disconnection and restarts. I am unable to reproduce this issue local so the CI should be ran a few times to ensure it works.

Closes: parse-community/parse-server#9149

Approach

  • Properly handle server shutdown
  • Refactor helper.js
  • Add retry strategy if server isn't properly initialized

@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Jun 23, 2024 •
edited
Loading

Thanks for opening this pull request!

@dplewis dplewis requested a review from a team June 23, 2024 17:19
@codecov Codecov
Copy link

codecov bot commented Jun 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (2b03abd).
Report is 83 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##             alpha     #2183    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6365   +179     
  Branches      1499      1534    +35     
==========================================
+ Hits          6186      6365   +179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit 450142c into parse-community:alpha Jun 25, 2024
9 checks passed
@mtrezza mtrezza mentioned this pull request Jun 28, 2024
Open
@dplewis dplewis deleted the invalid-server-state branch June 28, 2024 01:26
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 28, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 29, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky Tests Invalid server state: initialized
3 participants
@dplewis @parseplatformorg @mtrezza