Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support File Metadata #794

Open
3 tasks done
mbfakourii opened this issue Oct 6, 2022 · 6 comments
Open
3 tasks done

Support File Metadata #794

mbfakourii opened this issue Oct 6, 2022 · 6 comments
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature

Comments

@mbfakourii
Copy link
Member

New Feature / Enhancement Checklist

Current Limitation

It is not possible to send metadata along with the file

Feature / Enhancement Description

I suggest to add this possibility in this package, considering the addition of this possibility in Parse Server (PR)

this possibility allows us to send metadata such as file size with the file

Example Use Case

None

Alternatives / Workarounds

Another solution is like adding another field in higher classes, but it may make the schema crowded!

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added type:feature New feature or improvement of existing feature bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) labels Oct 6, 2022
@mbfakourii
Copy link
Member Author

According to @cbaker6 (this link), I don't think adding these items is necessary.

@cbaker6
Copy link

cbaker6 commented Dec 22, 2022

Hi @mbfakourii, my comments in the link you posted were more about the difference of the S3 and FS adapters on the server. If you want the Flutter SDK to support S3 metadata and tags, then the issue you opened is a valid one and you may want to add the feature if it’s missing. You can look at the Swift SDK for guidance. Essentially, the metadata and tags go into the header.

@mbfakourii
Copy link
Member Author

mbfakourii commented Dec 22, 2022

Hi @mbfakourii, my comments in the link you posted were more about the difference of the S3 and FS adapters on the server. If you want the Flutter SDK to support S3 metadata and tags, then the issue you opened is a valid one and you may want to add the feature if it’s missing. You can look at the Swift SDK for guidance. Essentially, the metadata and tags go into the header.

As far as I heard, S3 is being deprecated and the metadata and tags functions are only used in this adapter. Is it reasonable to work on this issue?

Are metadata and tags used in FS?

@mtrezza
Copy link
Member

mtrezza commented Dec 22, 2022

AWS S3 is not being deprecated. A Parse SDK can always transmit tags / metadata. How that info will be used depends on the storage adapter that Parse Server uses. If the storage adapter supports it, then tags / metadata will be processed, otherwise discarded.

Which storage adapter supports tags / metadata is irrelevant from this SDK's point of view. The only question is whether the SDK is capable of transmitting tags / metadata to the server. Whether a specific storage adapter supports tags / metadata is a question for Parse Server or its storage adapters (some of which have their own repos outside the Parse Sever repo).

The feature of tags / metadata goes beyond S3. For example, Azure's equivalent Blob also supports these tags / metadata.

So yes - it makes absolutely sense to add this feature to the Flutter SDK - and we'd be delighted if you could 🙂

@cbaker6
Copy link

cbaker6 commented Dec 22, 2022

Are metadata and tags used in FS?

This is what the link you posted in #794 (comment) is about. FS currently doesn’t use either. The FS adapter is a simple and useful one and has technically only had 2 code and test development contributors; Flo (original) and myself (mine were a major rewrite and feature addition). The current design is intended for file storage only. Anyone planning to add something else will need to understand the FS adapters current architecture to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

3 participants