Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused branches #759

Closed
3 tasks done
mtrezza opened this issue May 30, 2022 · 7 comments
Closed
3 tasks done

Delete unused branches #759

mtrezza opened this issue May 30, 2022 · 7 comments
Labels
type:meta Non-code issue

Comments

@mtrezza
Copy link
Member

mtrezza commented May 30, 2022

New Feature / Enhancement Checklist

Current Limitation

As we are moving to our org wide branch model as part of #668, let's delete the unused branches.

Feature / Enhancement Description

The goal is to remove all branches except for master. I already deleted the release branches release/... which only served to prepare the releases it seems. The tags are still here to point to the releases.

What about these branches:

I assume developement was used to merge features before merging them into master. The branch doesn't seem necessary anymore and it shouldn't contain any code that isn't also in master. If someone can confirm this, I'll go ahead and delete it. We are directly merging into master for now - in absence of a pre-release strategy, which makes most sense once we have fully automated releases, see #668.

The batch_saving branch looks like it should be a PR, but it's also an old branch from 2020. Can anyone confirm whether this feature has already been merged, has become obsolete, or the branch code should be preserved for future development? In the latter case, does anyone want to pick this up? Is there a related issue?

Example Use Case

n/a

Alternatives / Workarounds

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 30, 2022

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza
Copy link
Member Author

mtrezza commented May 30, 2022

@mtrezza mtrezza added the type:meta Non-code issue label May 30, 2022
@RodrigoSMarques
Copy link
Contributor

@mtrezza
The development branch is used before merging into master.

The master branch is used to keep the latest version available in production.

Then I create releases from the master's code versions. This is the flow I've been working on in git.

I don't know the batch_saving branch.

If the merge was not done, it is out of date.

If possible, keep the branch for a while to compare the code that has changed and evaluate the rewrite and a new PR.

@mtrezza
Copy link
Member Author

mtrezza commented May 31, 2022

  • I think we can delete the development brach, the compare doesn't show any commits except for the newer ones we did on master recently - would you agree?

  • Could you or @fischerscode take a look at the batch_saving, what it is and whether we still need the code there? Since we don't host PR branches in the repo anymore, it would also be great if someone could at least open a PR with it, so we can remove the branch.

@fischerscode
Copy link
Contributor

batch_saving

I'll have a look at it in a few hours.
Most likely I'll bring it to my fork to save the code.

@fischerscode
Copy link
Contributor

@mtrezza
I archived feature/batch_saving in my branch. link

You can delete it now.

If we add batch operations in the future, we can use the branch in my fork for reference, but we won't merge the changes from back then, esp. since back then null safety was not a thing.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 1, 2022

Great, thanks, I'll go ahead and remove all branches except for master.

@mtrezza mtrezza closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:meta Non-code issue
Projects
None yet
Development

No branches or pull requests

3 participants