Explicitly specify a data directory when exporting parachain genesis state #1519
Comments
|
Hi @JoshOrndorff, thanks for the heads up :) We can fix in zombienet by ensuring we just pass a unique Thx! |
|
I also considered using If you want to add I'm also fine if you just want to pass
|
…make it respect custom genesis block builders (#2331) Closes #2326. This PR both fixes a logic bug and replaces an incorrect name. ## Bug Fix: Respecting custom genesis builder Prior to this PR the standard logic for creating a genesis block was repeated inside of cumulus. This PR removes that duplicated logic, and calls into the proper `BuildGenesisBlock` implementation. One consequence is that if the genesis block has already been initialized, it will not be re-created, but rather read from the database like it is for other node invocations. So you need to watch out for old unpurged data during the development process. Offchain tools may need to be updated accordingly. I've already filed paritytech/zombienet#1519 ## Rename: It doesn't export state. It exports head data. The name export-genesis-state was always wrong, nad it's never too late to right a wrong. I've changed the name of the struct to `ExportGenesisHeadCommand`. There is still the question of what to do with individual nodes' public CLIs. I have updated the parachain template to a reasonable default that preserves compatibility with tools that will expect `export-genesis-state` to still work. And I've chosen not to modify the public CLIs of any other nodes in the repo. I'll leave it up to their individual owners/maintains to decide whether that is appropriate. --------- Co-authored-by: Joshy Orndorff <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
|
FYI, paritytech/polkadot-sdk#2331 is merged now, so this issue will be important soon. |
Thanks for the heads up @JoshOrndorff! I will fix asap and ping you for testing. |
When zombienet exports the parachain genesis state it uses a command like the following:
parachain-template-node export-genesis-state --chain /tmp/zombie-91732cca35cc89d9bc40d256bff11459_-279173-rjyW4YgPKWMA/2000-rococo-local.json > /tmp/zombie-91732cca35cc89d9bc40d256bff11459_-279173-rjyW4YgPKWMA/cfg/genesis-state-2000This has worked reliably so far, but only because of a bug in cumulus that I am now fixing. (See paritytech/polkadot-sdk#2326 and paritytech/polkadot-sdk#2331 for context.) Previously, Cumulus made some assumptions about the genesis block, and created a new one on the fly whenever you asked to export the genesis state. With this bug fixed, cumulus will now read the genesis block from the database instead of re-generating it 🚀
But that means that you will now need to make sure you are not implicitly using some pre-existing un-purged data directory.
The text was updated successfully, but these errors were encountered: