Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make subkey transfer feature optional or disableable via feature flag #2477

Closed
xlc opened this issue May 5, 2019 · 3 comments
Closed

Make subkey transfer feature optional or disableable via feature flag #2477

xlc opened this issue May 5, 2019 · 3 comments

Comments

@xlc
Copy link
Contributor

xlc commented May 5, 2019

I need to be able to do sr25519 in python/go/any non rust non js environment but there is no sr25519 library available AFAIK. So the quick workaround is invoke subkey via command line.

I want an executable that is small and lean but subkey currently depends on node-runtime which bundles the whole substrate runtime, which is not useful for my case and useless for any other non substrate chain.

It also make build slow.

Transfer feature can be enabled by default as long as there is a way to disable it during the build.

@xlc xlc changed the title Make subway transfer feature optional or protected by feature flag Make subkey transfer feature optional or protected by feature flag May 5, 2019
@xlc xlc changed the title Make subkey transfer feature optional or protected by feature flag Make subkey transfer feature optional or disableable via feature flag May 5, 2019
@burdges
Copy link

burdges commented May 9, 2019

We need someone to write C bindings for schnorrkel eventually. See w3f/schnorrkel#32

@folsen
Copy link
Contributor

folsen commented Jun 4, 2019

I think it makes sense to just build wrapper libraries around the rust sr25519 libraries here rather than depend on subkey at all, I don't think we should all be building all of our infrastructure around subkey because there is no native language support. The benefit of Rust is that you can generate C-bindings really easily, then use them in Python/Go/whatever.

@burdges
Copy link

burdges commented Jun 4, 2019

Someone did a partial one https://gitlab.com/kauriid/schnorrpy/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants