Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cargo.lock file of stable2412 release contains older crate versions than stable2409 #6982

Open
Daanvdplas opened this issue Dec 23, 2024 · 5 comments
Assignees

Comments

@Daanvdplas
Copy link
Contributor

Daanvdplas commented Dec 23, 2024

I am upgrading a chain to stable2412 and have encountered some problems. The Cargo.lock file in the release contains older crate versions than the previous release (e.g. frame-support is on v28.0.0, while on previous release it was on v38.0.0 (as a result psvm doesn't work)).

Is it expected of all downstream projects to transition to the polkadot-sdk crate? Is there any documentation / guide?

I'm a bit confused and would appreciate some help, thanks in advance :)

@kianenigma
Copy link
Contributor

Assigning @EgorPopelyaev to look into if the Cargo.lock works, and indeed psvm should also work per every new release. Ideally it's working should be part of a checklist.

Is it expected of all downstream projects to transition to the polkadot-sdk crate? Is there any documentation / guide?

It is up to you, but indeed you will not need to deal with dependency versions if you do this upgrade.

We have already moved some of the templates to the umbrella, more to be done.

For a user-friendly template, I'd highly recommend polakdot-sdk (and frame once it no longer needs experiemntal flag).

Guide: https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/reference_docs/umbrella_crate/index.html

@Daanvdplas
Copy link
Contributor Author

FYI: Cargo.lock in master also has the wrong versions

@Daanvdplas
Copy link
Contributor Author

Daanvdplas commented Dec 23, 2024

We have already moved some of the templates to the umbrella, more to be done.

Regarding this, I see that some dependencies are left in after moving to the umbrella crates (while being in the umbrella crate):

Any reason for this?

@Daanvdplas
Copy link
Contributor Author

Daanvdplas commented Dec 23, 2024

What is the correct version of the polkadot-sdk crate for the stable2412 release? As per above issue, the Cargo.lock file has v0.1.0. This version however doesn't have the node version so I can't imagine this being true.

Using v0.7.0 is that correct?

@kianenigma
Copy link
Contributor

The template sync jobs for templates are also failing, might be related: https://github.com/paritytech/polkadot-sdk/actions/workflows/misc-sync-templates.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants