Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore zombienet integration #2472

Closed
2 tasks
Tracked by #2538
svyatonik opened this issue Aug 2, 2022 · 10 comments
Closed
2 tasks
Tracked by #2538

Explore zombienet integration #2472

svyatonik opened this issue Aug 2, 2022 · 10 comments
Assignees
Labels
Monorepo migration Stuff to be done when we migrate to monorepo
Milestone

Comments

@svyatonik
Copy link
Contributor

It looks cool what Adrian has introduced for BEEFY (paritytech/polkadot#5840). Would it make sense for us to make some zombienet tests?

Main directions are:

  • whether we may use it in our CI pipeline for some basic tests? how long would it take to spin it up and make finality+message delivery?;
  • whether we may use it in Cumulus/Polkadot pipeline (or for standalone tests) for some basic tests of R<>W or P<>K bridges? same questions.
@EmmanuellNorbertTulbure
Copy link

@bkontur is this similar to what you have implemented, right?

@bkontur
Copy link
Contributor

bkontur commented Dec 6, 2022

partially, I use zombienet for local run,
but we would/should add some integration tests to CI (Cumulus) or manual run with asset transfer (statemine/t),
so we will come back to this issue later

@EmmanuellNorbertTulbure
Copy link

@serban300 to take a look.

@serban300
Copy link
Collaborator

I researched this issue a bit. It seems that cumulus uses zndsl zombienet tests:

The problem is that zndsl allows to start only one network. Looking on the zombienet code, I think it could be extended to start multiple networks. Created an issue for this in order to get feedback from the zombienet mainteainers: paritytech/zombienet#788

@serban300
Copy link
Collaborator

Also opened a draft PR in zombienet that adds support for multiple networks in zndsl tests: paritytech/zombienet#792

Might be missing some corner cases and might need some polishing, but overall adding support for multiple networks seems possible.

@serban300
Copy link
Collaborator

Covered corner cases and polished the code. The zombienet PR for adding multiple networks support is ready for review: paritytech/zombienet#788 . Waiting on it.

@serban300
Copy link
Collaborator

The zombienet team decided that it would be better to support this use case with a different cli tool that they will be working on. Some details here: paritytech/zombienet#796 (comment)

We'll wait for the new tool

@bkontur
Copy link
Contributor

bkontur commented May 2, 2023

ok, only one zombienet could totally simplify local run, but lets wait for a new tool,
and also there is a new test feature coming soon "xcm-emulator", which could be useful for testing bridge-hub with several runtimes: #2421

svyatonik referenced this issue Jul 17, 2023
* [ci] improve cancel-pipeline job

* fix trigger

* fix trigger

* add file to trigger

* test job fail

* fix trigger

* fix indent

* fix before_script

* add comment

* remove debuag fail from test-linux-stable
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure transferred this issue from paritytech/parity-bridges-common Aug 25, 2023
@the-right-joyce the-right-joyce transferred this issue from paritytech/polkadot-sdk Aug 25, 2023
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure added this to the Nice To Have milestone Sep 1, 2023
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure added the Monorepo migration Stuff to be done when we migrate to monorepo label Sep 1, 2023
@svyatonik svyatonik self-assigned this Oct 20, 2023
@svyatonik
Copy link
Contributor Author

I'll try to play with zombienet tests here (in this repo). We may then (try to) migrate those tests to polkadot-sdk

@svyatonik
Copy link
Contributor Author

I'm gonna close it - we now have a basic test (unfortunately with a hacky test runner) in polkadot-sdk CI. If zombienet will ever have a native support for multiple relay chains, we can continue work in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monorepo migration Stuff to be done when we migrate to monorepo
Projects
None yet
Development

No branches or pull requests

4 participants