Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling #31

Open
MatthijsvanNoort opened this issue Nov 13, 2024 · 0 comments
Open

Better error handling #31

MatthijsvanNoort opened this issue Nov 13, 2024 · 0 comments

Comments

@MatthijsvanNoort
Copy link

MatthijsvanNoort commented Nov 13, 2024

M247p3 | PHP8.2
Please check this issue, that killed the checkout process in my case, preventing sales.
Although the parcelPro module was disabled in Stores->Configuration->Sales->Delivery Methods...

CRITICAL: Exception: Deprecated Functionality: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /[...]/vendor/parcelpro/shipment/Observer/Shipment.php on line 51 in

What happens there:
if (strtolower($config["auto_status"]) == 'pending') {

There's two things wrong here.

  1. The dropdown values for statusses weren't set yet. So there is no error handling for that here.
  2. The module was not enabled in the admin, so why is all this fired at all
Scherm­afbeelding 2024-11-13 om 12 00 02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant