Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address of selected pickup point not stored in order data #29

Open
MatthijsvanNoort opened this issue Jun 12, 2024 · 0 comments
Open

Address of selected pickup point not stored in order data #29

MatthijsvanNoort opened this issue Jun 12, 2024 · 0 comments

Comments

@MatthijsvanNoort
Copy link

Using
Firecheckout 1.31.1
magento/product-community-edition 2.4.6-p4
parcelpro/shipment 2.18.1

First i thought it was because Location picker generates error on popup close.

shipping-mixin.js:93 Uncaught TypeError: Cannot read properties of null (reading 'validateShippingInformation')
 at popup_close (shipping-mixin.js:93:22) at shipping-mixin.js:178:33

In vendor/parcelpro/shipment/view/frontend/web/js/view/shipping-mixin.js line 93

        function popup_close() {
            jQuery('#modal').hide();
            instance.validateShippingInformation();
        }

but the only instance mentioned in the js file is line 53
var instance = null;

So no wonder it generates this error...

Although i succeed in avoiding this js error, bottom line is: The Pickup Point Address is not saved in the order.
I don't see it anywhere in backend or print labels.

I can see in previous orders that the shipment address was replaced by the pickup point's address.
I came from an older version of the plugin, in which this part did work, but then the admin failed on 'Verzending aanmelden' & 'Print Label'.

last try,
I noticed this line in requirejs mentioning FireCheckout, but adding that to requirejs didn't change a thing
"Magento_Checkout/js/action/set-shipping-information":"Parcelpro_Shipment/js/action/set-shipping-information"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant