From 7e760bcede505b82e3ac5ee7428b8d18f21275e6 Mon Sep 17 00:00:00 2001 From: Alexander Burkut Date: Fri, 4 Oct 2024 14:01:18 +0300 Subject: [PATCH 1/4] Remove incorrect comment for CurveV2 about needWrapNative --- src/dex/curve-v2/curve-v2.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/dex/curve-v2/curve-v2.ts b/src/dex/curve-v2/curve-v2.ts index f28bb5e2e..147b2b06f 100644 --- a/src/dex/curve-v2/curve-v2.ts +++ b/src/dex/curve-v2/curve-v2.ts @@ -94,7 +94,6 @@ export class CurveV2 exchangeRouterInterface: Interface; genericFactoryZapIface: Interface; minConversionRate = '1'; - // TODO: it's wrong, cause some pools can have eth and others can have weth needWrapNative = true; logger: Logger; From ec4d36951688b6efacdee7e467b5b7193ab73bd4 Mon Sep 17 00:00:00 2001 From: Alexander Burkut Date: Fri, 4 Oct 2024 14:42:44 +0300 Subject: [PATCH 2/4] Update comment --- src/dex/curve-v2/curve-v2.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dex/curve-v2/curve-v2.ts b/src/dex/curve-v2/curve-v2.ts index 147b2b06f..769b54dc5 100644 --- a/src/dex/curve-v2/curve-v2.ts +++ b/src/dex/curve-v2/curve-v2.ts @@ -94,6 +94,7 @@ export class CurveV2 exchangeRouterInterface: Interface; genericFactoryZapIface: Interface; minConversionRate = '1'; + // the dex supports native ETH and WETH pool, but wrapping/unwrapping is handled on dex level, we can always send WETH event for native ETH pools needWrapNative = true; logger: Logger; From a6bb0c2a8579078d4cba97e400ff7473ebb2978f Mon Sep 17 00:00:00 2001 From: Alexander Burkut Date: Fri, 4 Oct 2024 14:43:29 +0300 Subject: [PATCH 3/4] update typos --- src/dex/curve-v2/curve-v2.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dex/curve-v2/curve-v2.ts b/src/dex/curve-v2/curve-v2.ts index 769b54dc5..706f731c7 100644 --- a/src/dex/curve-v2/curve-v2.ts +++ b/src/dex/curve-v2/curve-v2.ts @@ -94,7 +94,7 @@ export class CurveV2 exchangeRouterInterface: Interface; genericFactoryZapIface: Interface; minConversionRate = '1'; - // the dex supports native ETH and WETH pool, but wrapping/unwrapping is handled on dex level, we can always send WETH event for native ETH pools + // the dex supports native ETH and WETH pools, but wrapping/unwrapping is handled on dex level, we can always send WETH even for native ETH pools needWrapNative = true; logger: Logger; From 6070c26573b0fd20feb36c808d70b2da47a9b867 Mon Sep 17 00:00:00 2001 From: Alexander Burkut Date: Fri, 4 Oct 2024 14:52:23 +0300 Subject: [PATCH 4/4] update comment --- src/dex/curve-v2/curve-v2.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dex/curve-v2/curve-v2.ts b/src/dex/curve-v2/curve-v2.ts index 706f731c7..4169a03f8 100644 --- a/src/dex/curve-v2/curve-v2.ts +++ b/src/dex/curve-v2/curve-v2.ts @@ -94,7 +94,7 @@ export class CurveV2 exchangeRouterInterface: Interface; genericFactoryZapIface: Interface; minConversionRate = '1'; - // the dex supports native ETH and WETH pools, but wrapping/unwrapping is handled on dex level, we can always send WETH even for native ETH pools + // the dex supports native ETH and WETH pools and handles wrapping/unwrapping on their smart contract level, we can always send WETH even for native ETH pools needWrapNative = true; logger: Logger;