command token mapping oddity

[konimaru]

Is this token mapping on purpose (if so why?) or is it really just a bug?

Parallax-ESP/parallax/sscp.c

Line 500 in 59521b7

case SSCP_TKN_JOIN: name = "HTTP"; sep = ':'; break;

[dbetz]

Parallax asked for that mapping. I think it was a last minute change. I guess the token name should have been changed as well.

[konimaru]

The reason I raised this issue is that there is a mapping for HTTP and this one (above) for JOIN. Both get mapped to HTTP which can't be right. A token based join command simply wouldn't work.

case SSCP_TKN_JOIN:     name = "HTTP";    sep = ':'; break;
case SSCP_TKN_CHECK:    name = "CHECK";   sep = ':'; break;
...
case SSCP_TKN_FRUN:     name = "FRUN";    sep = ':'; break;
case SSCP_TKN_HTTP:     name = "HTTP";    sep = ','; break;

[dbetz]

Hmmm... I'll have to look into that further. I remember Parallax asking for a "JOIN" command but maybe there was an error made in implementing it. Thanks for pointing this out.