Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust 4xx error codes #19

Open
PropGit opened this issue Feb 13, 2017 · 1 comment
Open

Adjust 4xx error codes #19

PropGit opened this issue Feb 13, 2017 · 1 comment

Comments

@PropGit
Copy link

PropGit commented Feb 13, 2017

Adjust some 4xx error codes that relate to internal loader handling for Propeller discovery and communication errors so that the external PropLoader can apply special processing to those cases. This relates to PropLoader Issue #28.

Currently, many Propeller loading errors simply use the code 400 and the PropLoader treats them all the same.

Specifically, some more general errors can keep the 400 coded response, but others, like "Propeller not found,", "Rx Handshake timeout," "Invalid Rx handshake," "Version response timeout," and "Invalid version response," should have unique codes, like 401, 402, 403, etc.

(some of these error messages are made up during this writing, but need to be errors if they don't already exist).

@PropGit
Copy link
Author

PropGit commented Mar 22, 2018

Resolved by returning an error text message with every 400 result. PropLoader now uses those text messages to do something sensible.

Needs verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants