feat(primitives): move header validation methods from consensus to primitive

[tcoratger]

Describe the feature

At the moment, in this file:

https://github.com/paradigmxyz/reth/blob/2a9fa4869e658ca89e050d0d985a7ccbfa360bfa/crates/consensus/common/src/validation.rs

we have a lot of header validation methods like this one:

reth/crates/consensus/common/src/validation.rs

Lines 14 to 24 in 2a9fa48

	/// Gas used needs to be less than gas limit. Gas used is going to be checked after execution.
	#[inline]
	pub fn validate_header_gas(header: &SealedHeader) -> Result<(), ConsensusError> {
	if header.gas_used > header.gas_limit {
	return Err(ConsensusError::HeaderGasUsedExceedsGasLimit {
	gas_used: header.gas_used,
	gas_limit: header.gas_limit,
	})
	}
	Ok(())
	}

I have the impression that rather than keeping these methods here, it would make more sense to integrate them into the SealedHeader implementation with a specific error type HeaderConsensusError which would group together all possible errors when validating the sealed headers and which would then be passed transparently to the ConsensusError.

This would make it possible to make the implementation more structural and to use:

header.validate_gas();

for example.

Additional context

No response

[Villegas2003]

Hi @tcoratger , Are you still in need of support for this issue? I'd be happy to help.

[tcoratger]

Hi @tcoratger , Are you still in need of support for this issue? I'd be happy to help.

@Villegas2003 Before you start working on it, I don't know if this proposal will be accepted, wdyt @mattsse ?

[github-actions]

This issue is stale because it has been open for 21 days with no activity.