Remove optimism feature

[emhane]

Describe the feature

Gathers issues to re-design code to remove optimism feature. Features are convenient for building fast, but in the long run make the code harder to maintain.

A generalisation of the codebase in terms of EVM rollup injectable types, is required to extract OP as a library as, opposed to having OP as a feature.

Additional context

No response

Tasks

Preview Give feedback

1. Copy db consistency check to reth-optimism-storage #13441
   A-db A-op-reth A-sdk C-debt S-needs-design +5
2. Separate OP payload builder in new engine #13440
   A-consensus A-op-reth A-sdk C-debt S-needs-design +5
3. Feature audit: optimism #11116
   A-dependencies A-op-reth C-debt D-complex +4
   
4. Remove feature = "optimism" from reth-optimism-payload-builder #6906
   1 of 1
   C-debt +1
   
5. OP specific beacon consensus crate #7648
   A-op-reth C-debt D-good-first-issue +3
6. fix: Use OptimismBeaconConsensus in the OptimismNode #8487
   A-op-reth +1
   
7. Enable discv5 for op in reth-node-optimism crate #8499
   A-op-reth C-debt D-good-first-issue +3
   
8. feat: group optimism crates #7740
   C-debt +1
9. feat: add OP specific txpool #6902
   A-op-reth C-enhancement +2
10. Remove optimism feature from rpc crates #8988
    20 of 20
    A-op-reth A-rpc C-tracking-issue M-prevent-stale +4
11. Remove Optimism feature from chainspec #8904
    10 of 10
    C-debt C-tracking-issue M-prevent-stale +3
12. Remove optimism feature from reth-primitives #10515
    4 of 4
    A-op-reth C-debt C-tracking-issue M-prevent-stale +4
13. Remove optimism feature from consensus #11109
    5 of 5
    A-consensus A-op-reth A-sdk C-debt C-tracking-issue +5
14. Copy tests in reth_execution_types::chain to reth-evm-optimism #11111
    A-op-reth C-debt C-test D-good-first-issue +4
    
15. Move op storage tests into new crate reth-optimism-storage #11172
    A-op-reth C-debt C-test D-good-first-issue +4
16. Add trait abstraction for TransactionSigned #11253
    A-op-reth A-sdk C-debt +3
    
17. Remove optimism re-export in reth-primitives #11434
    A-dependencies A-op-reth C-debt +3
18. Add reth Receipt trait #11530
    A-sdk C-debt +2
    
19. Define trait Transaction #11533
    A-sdk C-debt D-good-first-issue +3
    
20. Define trait TxType #11531
    A-sdk C-debt D-good-first-issue +3
    
21. Copy OP execution outcome tests #11534
    A-op-reth C-test D-good-first-issue +3
22. Move OP codecs test #11536
    A-op-reth C-test D-complex S-wontfix +4
23. Define trait Signature #11566
    A-op-reth A-sdk C-debt +3
24. Define OpSignature #11572
    A-op-reth A-sdk C-debt +3
25. Make ExecutionOutcome generic over receipt collection type #11108
    1 of 1
    A-consensus A-execution A-op-reth A-sdk C-debt +5
    
26. Move optimism execution types test to optimism crate #11792
    C-debt D-good-first-issue +2
27. Implement SignedTransaction for Transaction #12169
    A-sdk C-enhancement +2
    
28. Define OpTxType #12333
    A-op-reth A-sdk +2
    
29. OVM block file codec #12184
    A-op-reth D-good-first-issue +2
    
30. Define OpTransactionSigned #11575
    A-op-reth A-sdk C-debt +3
31. Define OpTransaction #12473
    A-op-reth A-sdk C-debt D-good-first-issue +4
    
32. Make FileClient generic over codec #12475
    A-cli C-debt D-good-first-issue +3
    
33. Implement Compact for OpTxType #12516
    A-op-reth A-sdk C-debt D-good-first-issue +4
34. Plug ovm codec into ImportOpCommand #12587
    A-cli A-op-reth C-debt S-wontfix +4
    
35. Define OpReceipt #12588
    A-op-reth A-sdk C-debt D-good-first-issue +4
    

[supernovahs]

I can take this?

[onbjerg]

@supernovahs This is a longer term project and requires re-architecting some parts of the node and node dependencies, which requires high context. We are not currently looking to outsource this, but thank you for your interest :)