Generic block for BlockchainTreeAction

[emhane]

Describe the feature

Make BlockchainTreeAction generic over block as BlockchainTreeAction<EngineT: EngineTypes, B: reth_primitives_traits::Block> and generalise type nested in variants SealedBlock to SealedBlockFor<B>

reth/crates/consensus/beacon/src/engine/mod.rs

Lines 1938 to 1974 in 5b19bad

	enum BlockchainTreeAction<EngineT: EngineTypes> {
	MakeForkchoiceHeadCanonical {
	state: ForkchoiceState,
	attrs: Option<EngineT::PayloadAttributes>,
	tx: oneshot::Sender<RethResult<OnForkChoiceUpdated>>,
	},
	InsertNewPayload {
	block: SealedBlock,
	tx: oneshot::Sender<Result<PayloadStatus, BeaconOnNewPayloadError>>,
	},
	MakeNewPayloadCanonical {
	payload_num_hash: BlockNumHash,
	status: PayloadStatus,
	tx: oneshot::Sender<Result<PayloadStatus, BeaconOnNewPayloadError>>,
	},
	/// Action to insert a new block that we successfully downloaded from the network.
	/// There are several outcomes for inserting a downloaded block into the tree:
	///
	/// ## [`BlockStatus::Valid`]
	///
	/// The block is connected to the current canonical chain and is valid.
	/// If the block is an ancestor of the current forkchoice head, then we can try again to
	/// make the chain canonical.
	///
	/// ## [`BlockStatus::Disconnected`]
	///
	/// The block is not connected to the canonical chain, and we need to download the
	/// missing parent first.
	///
	/// ## Insert Error
	///
	/// If the insertion into the tree failed, then the block was well-formed (valid hash),
	/// but its chain is invalid, which means the FCU that triggered the
	/// download is invalid. Here we can stop because there's nothing to do here
	/// and the engine needs to wait for another FCU.
	InsertDownloadedPayload { block: SealedBlock },
	}

Additional context

No response

[mattsse]

marking this as blocked because we need to figure out if we even have to do this because ideally we retire this entire thing asap

[emhane]

ah, you mean as a side effect of #12750 @mattsse ?