You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Its quite common to have npm dependencies that needs additional tools/binaries during its installation, e.g. cp, c++, make, etc, especially when using node-gyp. So when npm install / yarn install runs, these additional tools would need to be included in the sandbox's binary shims.
Currently we have a hardcoded set of tools that are included in the sandbox:
, but iiuc there is no way to specify such additional tools.
Describe the solution you'd like
Maybe we could have an option tools on the nodejs subsystem where we could specify which additional tools to include during nodejs processes invocation, similar to the tools option we have on the docker subsystem: https://www.pantsbuild.org/2.22/reference/subsystems/docker#tools.
Describe alternatives you've considered
None.
Additional context
When such additional tools are not included in the sandbox, e.g. cp, the package manager installation, in this case yarn install, fails with:
/bin/sh: cp: command not found
make: *** [../build/bindings/iltorb.node] Error 127
gyp ERR! build error
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Its quite common to have npm dependencies that needs additional tools/binaries during its installation, e.g.
cp
,c++
,make
, etc, especially when using node-gyp. So whennpm install
/yarn install
runs, these additional tools would need to be included in the sandbox's binary shims.Currently we have a hardcoded set of tools that are included in the sandbox:
pants/src/python/pants/backend/javascript/subsystems/nodejs.py
Lines 351 to 367 in 0d139ea
Describe the solution you'd like
Maybe we could have an option
tools
on thenodejs
subsystem where we could specify which additional tools to include during nodejs processes invocation, similar to thetools
option we have on thedocker
subsystem: https://www.pantsbuild.org/2.22/reference/subsystems/docker#tools.Describe alternatives you've considered
None.
Additional context
When such additional tools are not included in the sandbox, e.g.
cp
, the package manager installation, in this caseyarn install
, fails with:The text was updated successfully, but these errors were encountered: