Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails PR to avoid usage of field_error_proc action view config #56

Open
nicolas-brousse opened this issue Sep 11, 2021 · 3 comments
Open
Labels
discussion Let's discuss ideas and features documentation Improvements or additions to documentation nice to have We are not working on it but we're open to contributions
Milestone

Comments

@nicolas-brousse
Copy link
Member

nicolas-brousse commented Sep 11, 2021

It may be very nice to find a proposal for Rails to avoid having this kind of config in application. And/Or having something configurable from FormBuilder.

    config.action_view.field_error_proc = proc { |html_tag, _instance|
      html_tag.html_safe
    }

cc @Spone

@nicolas-brousse nicolas-brousse added the discussion Let's discuss ideas and features label Sep 11, 2021
@Spone
Copy link
Collaborator

Spone commented Sep 13, 2021

I found the following related issue rails/rails#39522

@thebravoman
Copy link

Hey, just wanted to share that I am thinking on an approach to have the logic in the FormBuilder and I have proposed an implementation.

As per Rails Contribution guides I would like to first get feedback before opening a new PR. Let me know your thoughts in https://discuss.rubyonrails.org/t/feature-allow-for-override-of-field-error-proc-in-the-formbuilder-could-prepare-pr-if-the-approach-is-reasonable/79843

@Spone Spone added the nice to have We are not working on it but we're open to contributions label Feb 2, 2023
@Spone
Copy link
Collaborator

Spone commented Feb 2, 2023

Maybe we could start by documenting this in the README?

@Spone Spone added the documentation Improvements or additions to documentation label Feb 2, 2023
@Spone Spone added this to the v0.3 milestone Feb 2, 2023
@Spone Spone mentioned this issue Feb 2, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Let's discuss ideas and features documentation Improvements or additions to documentation nice to have We are not working on it but we're open to contributions
Projects
None yet
Development

No branches or pull requests

3 participants