Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore this. #111

Closed
pboling opened this issue Feb 24, 2022 · 1 comment · Fixed by #118
Closed

Ignore this. #111

pboling opened this issue Feb 24, 2022 · 1 comment · Fixed by #118

Comments

@pboling
Copy link

pboling commented Feb 24, 2022

Good-by view_component-form, we hardly knew ye.

@pboling pboling changed the title Undeclared dependency on actiontext gem Bug: Missing Dependency - actiontext Feb 28, 2022
@tmaier
Copy link
Contributor

tmaier commented Mar 8, 2022

Since I added the ViewComponent::Form to the main branch of my application all deployments to a production-like environment fail. So I would say this is a severe issue

And the reason for this is, this topic.

Since I am not using actiontext at all, I disabled it among other things in my application.

Excerpt from application.rb
# frozen_string_literal: true

require_relative 'boot'

require 'rails'
# Pick the frameworks you want:
require 'active_model/railtie'
require 'active_job/railtie'
require 'active_record/railtie'
# require "active_storage/engine"
require 'action_controller/railtie'
require 'action_mailer/railtie'
# require "action_mailbox/engine"
# require "action_text/engine"
require 'action_view/railtie'
require 'action_cable/engine'
# require "sprockets/railtie"
require 'rails/test_unit/railtie'

I would not like to have this as a strong dependency.
I would especially not like it, if it would require automatically action_text, even though I voted against it in application.rb

Instead, it should behave similarly to what you propose for country_select at #41: Only provide that helper, if defined?(ActionView::Helpers::Tags::ActionText)

@pboling pboling closed this as completed Mar 9, 2022
@pboling pboling changed the title Bug: Missing Dependency - actiontext Ignore this. Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants