-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redis clear #2355
Draft
kyletaylored
wants to merge
2
commits into
pantheon-systems:3.x
Choose a base branch
from
kyletaylored:add-redis-clear
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Redis clear #2355
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<?php | ||
|
||
namespace Pantheon\Terminus\Commands\Redis; | ||
|
||
use Pantheon\Terminus\Commands\TerminusCommand; | ||
use Pantheon\Terminus\Commands\WorkflowProcessingTrait; | ||
use Pantheon\Terminus\Exceptions\TerminusProcessException; | ||
use Pantheon\Terminus\Site\SiteAwareInterface; | ||
use Pantheon\Terminus\Site\SiteAwareTrait; | ||
|
||
/** | ||
* Class ClearCommand | ||
* @package Pantheon\Terminus\Commands\Redis | ||
*/ | ||
class ClearCommand extends TerminusCommand implements SiteAwareInterface | ||
{ | ||
use SiteAwareTrait; | ||
use WorkflowProcessingTrait; | ||
|
||
/** | ||
* Clear the Redis cache for a site environment. | ||
* | ||
* @authorize | ||
* | ||
* @command redis:clear | ||
* | ||
* @param string $site_id Site name | ||
* | ||
* @usage <site> Clear the Redis cache for <site>. | ||
* | ||
* @throws \Pantheon\Terminus\Exceptions\TerminusProcessException | ||
* @throws \Pantheon\Terminus\Exceptions\TerminusException | ||
*/ | ||
public function clear($site_env) | ||
{ | ||
$this->requireSiteIsNotFrozen($site_env); | ||
$site = $this->getSite(); | ||
$env = $this->getEnv($site_env); | ||
|
||
$workflow = $site->getRedis()->clear($env); | ||
$this->processWorkflow($workflow); | ||
$this->log()->notice($workflow->getMessage()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 on adding flags to the existing env:cc command. Note that it's not reliable to turn off the varnish cache here, as the Drupal hook will clear the varnish cache even if the ygg workflow does not.
The existing behavior may be inconsistent with WordPress, i.e. WordPress might not clear the varnish cache if the ygg workflow does not. Ideally we would fix WordPress, and hook its cache clear operation the same way we do for Drupal. Maybe having ygg clear the varnish cache invariantly here would be a reasonable workaround.