Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List required ext-xml in composer.json. #2010

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Conversation

mbaynton
Copy link
Contributor

@mbaynton mbaynton commented Sep 8, 2019

I think it's easy enough for a user's first experience with terminus to go something like:

$ curl -O https://raw.githubusercontent.com/pantheon-systems/terminus-installer/master/builds/installer.phar && php installer.phar install
$ bin/terminus
PHP Fatal error:  Uncaught ReflectionException: Class DOMDocument does not exist in /home/mpantheon/terminus/vendor/consolidation/output-formatters/src/Transformations/DomToArraySimplifier.php:24

This PR is one of several possible UX improvements, with just this we get at installation

Loading composer repositories with package information
Installing dependencies from lock file
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested PHP extension ext-xml * is missing from your system. Install or enable PHP's xml extension.

We could perhaps also iterate on this to add our own checks in the installer and/or in terminus itself for users of the .phar, but I think this change is fine regardless to make the composer.json more correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant