Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astype tests failing for f16, float128, c32 and complex256 on MacOS arm64 platforms #1051

Open
loicdiridollou opened this issue Nov 22, 2024 · 2 comments · May be fixed by #1057
Open

astype tests failing for f16, float128, c32 and complex256 on MacOS arm64 platforms #1051

loicdiridollou opened this issue Nov 22, 2024 · 2 comments · May be fixed by #1057

Comments

@loicdiridollou
Copy link
Contributor

Describe the bug

MacOS arm64 (M1 and above) platforms do not recognize some dtypes from

FAILED tests/test_series.py::test_astype_float['f16'-<class 'numpy.longdouble'>] - TypeError: data type 'f16' not understood
FAILED tests/test_series.py::test_astype_float['float128'-<class 'numpy.longdouble'>] - TypeError: data type 'float128' not understood
FAILED tests/test_series.py::test_astype_complex['c32'-<class 'numpy.clongdouble'>] - TypeError: data type 'c32' not understood
FAILED tests/test_series.py::test_astype_complex['complex256'-<class 'numpy.clongdouble'>] - TypeError: data type 'complex256' not understood

To Reproduce
Run poetry run poe test_all on a Mac M1 or above (for reference I ran a build on GitHub Actions, see https://github.com/loicdiridollou/pandas-stubs/actions/runs/11981847576/job/33408829929)

Please complete the following information:

  • OS: MacOS
  • OS Version 15
  • python version 3.10/3.11/3.12/3.13
  • version of type checker NA
  • version of installed pandas-stubs NA
@loicdiridollou loicdiridollou changed the title Skip astype tests for f16, float128, c32 and complex256 on MacOS arm64 platforms astype tests failing for f16, float128, c32 and complex256 on MacOS arm64 platforms Nov 22, 2024
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Nov 25, 2024

This is pretty straightforward to fix. The tests in tests/test_series.py for those 4 types should be skipped at runtime if platform.processor() is arm

Ideally, we'd also have a Github action that would do tests on Mac ARM so this (and anything else) would be caught there.

@loicdiridollou
Copy link
Contributor Author

loicdiridollou commented Nov 25, 2024 via email

@loicdiridollou loicdiridollou linked a pull request Nov 26, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH1051 Drop astype tests for Mac arm for float128 and complex256 loicdiridollou/pandas-stubs
2 participants
@Dr-Irv @loicdiridollou